Template talk:Infobox NRHP

adding a map to an NRHP template

I would like to upload a GeoJSON encoded map of Austin and Northwestern Railroad Historic District-Fairland to Llano to wikipedia but it's not clear to me how to do so.

The map lives here: https://commons.wikimedia.org/wiki/Data:ANWR.map

For rivers I'd add | map = {{maplink-road|from=ANWR.map}} to the infobox but when I try to do that for Austin and Northwestern Railroad Historic District-Fairland to Llano I get a Preview warning: Page using Template:Infobox NRHP with unknown parameter "map" error.

Any ideas? TerraFrost (talk) 20:18, 11 June 2022 (UTC)

|map= is not a valid parameter. The documentation for this template lists a few different ways to display a map. I think you want |district_map=. – Jonesey95 (talk) 21:04, 11 June 2022 (UTC)

That did the trick - thanks! TerraFrost (talk) 21:06, 11 June 2022 (UTC)

"mapframe-custom" is another option, which prevents duplicate maps in the case the Infobox ever gets automatic-display mapframe maps. Or you can add mapframe options without needing to really add the full mapframe/maplink-road. ɱ (talk) 03:16, 12 June 2022 (UTC)

add "increase4=", "decrease4=" parameters

I came here to say that for St. Charles Historic District and perhaps other HDs already, and for more in the future, the template needs to accommodate "increase3=" parameter. Many NRHP-listed HDs will just keep growing and changing. I would say also, while at it, add "increase4=" and "decrease4=" parameters.

Here, I find the existing relevant code does apparently already address "increase3=", and then I went back to check and fix the usage in St. Charles Historic District. Apparently "increase3= was not previously available when that infobox was set up, but now it is, and.... Yay, it works!

Anyhow, and less urgently, why not now add the code to handle fourth increase and fourth decrease?

Extended content

The existing relevant code is: |data22 = {{#if:{{{refnum|}}}|{{#invoke:String|replace|{{{refnum}}}|^%s*(%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}}}}{{#if:{{{increase_refnum|{{{increase1_refnum|}}}}}}| (original)<br />{{#invoke:String|replace|{{{increase_refnum|{{{increase1_refnum}}}}}}|(%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (increase{{#if:{{{increase2_refnum|}}}| 1}}){{#if:{{{increase2_refnum|}}}|<br />{{#invoke:String|replace|{{{increase2_refnum}}}|(%d%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (increase 2)}}{{#if:{{{increase3_refnum|}}}|<br />{{#invoke:String|replace|{{{increase3_refnum}}}|(%d%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (increase 3)}}}}{{#if:{{{decrease_refnum|{{{decrease1_refnum|}}}}}}|<br />{{#invoke:String|replace|{{{decrease_refnum|{{{decrease1_refnum|}}}}}}|(%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (decrease{{#if:{{{decrease2_refnum|}}}| 1}}){{#if:{{{decrease2_refnum|}}}|<br />{{#invoke:String|replace|{{{decrease2_refnum}}}|(%d%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (decrease 2)}}{{#if:{{{decrease3_refnum|}}}|<br />{{#invoke:String|replace|{{{decrease3_refnum}}}|(%d%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (decrease 3)}}}} Trying to understand that code without changing anything except adding returns, the code is as follows [and then I add coding for increase 4 and decrease 4]: if there's a refnum= value, then put in a NRHP focus link for it: |data22 = {{#if:{{{refnum|}}}|{{#invoke:String|replace|{{{refnum}}}|^%s*(%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}}}} if there's an increase= value, then put in a NRHP focus link for it, labelled "(increase)" (unless this will be followed by an increase2=value, then label the first increase as "(increase 1)"): {{#if:{{{increase_refnum|{{{increase1_refnum|}}}}}}| (original)<br />{{#invoke:String|replace|{{{increase_refnum|{{{increase1_refnum}}}}}}|(%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (increase{{#if:{{{increase2_refnum|}}}| 1}}) if there's an increase2= value, then put in a NRHP focus link for it, labelled "(increase 2)": {{#if:{{{increase2_refnum|}}}|<br />{{#invoke:String|replace|{{{increase2_refnum}}}|(%d%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (increase 2)}} if there's an increase3= value, then put in a NRHP focus link for it, labelled "(increase 3)": {{#if:{{{increase3_refnum|}}}|<br />{{#invoke:String|replace|{{{increase3_refnum}}}|(%d%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (increase 3)}} [if there's an increase4= value, then put in a NRHP focus link for it, labelled "(increase 4)"]: {{#if:{{{increase4_refnum|}}}|<br />{{#invoke:String|replace|{{{increase4_refnum}}}|(%d%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (increase 4)}} and close the apparently-open double squiggly parenthesis: }} and for decrease (or decrease1), decrease2, decrease3 [, and decrease4]: {{#if:{{{decrease_refnum|{{{decrease1_refnum|}}}}}}|<br />{{#invoke:String|replace|{{{decrease_refnum|{{{decrease1_refnum|}}}}}}|(%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (decrease{{#if:{{{decrease2_refnum|}}}| 1}}) {{#if:{{{decrease2_refnum|}}}|<br />{{#invoke:String|replace|{{{decrease2_refnum}}}|(%d%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (decrease 2)}} {{#if:{{{decrease3_refnum|}}}|<br />{{#invoke:String|replace|{{{decrease3_refnum}}}|(%d%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (decrease 3)}} [accommodate decrease 4]: {{#if:{{{decrease4_refnum|}}}|<br />{{#invoke:String|replace|{{{decrease4_refnum}}}|(%d%d+)|[{{NRHP Focus|%1|url=yes}} %1]|1|false}} (decrease 4)}} and close the apparently-open double squiggly parenthesis: }} And further the lists of dates of increases and decreases need to change from: |label35 = Boundary increase{{#if:{{{increase2|}}}|s}} |data35 = {{{increase|{{{increase1|}}}}}}{{#if:{{{increase2|}}}|<br />{{{increase2}}}}}{{#if:{{{increase3|}}}|<br />{{{increase3}}}}} |label36 = Boundary decrease{{#if:{{{decrease2|}}}|s}} |data36 = {{{decrease|{{{decrease1|}}}}}}{{#if:{{{decrease2|}}}|<br />{{{decrease2}}}}}{{#if:{{{decrease3|}}}|<br />{{{decrease3}}}}} to: |label35 = Boundary increase{{#if:{{{increase2|}}}|s}} |data35 = {{{increase|{{{increase1|}}}}}} {{#if:{{{increase2|}}}|<br />{{{increase2}}}}} {{#if:{{{increase3|}}}|<br />{{{increase3}}}}} {{#if:{{{increase4|}}}|<br />{{{increase4}}}}} |label36 = Boundary decrease{{#if:{{{decrease2|}}}|s}} |data36 = {{{decrease|{{{decrease1|}}}}}} {{#if:{{{decrease2|}}}|<br />{{{decrease2}}}}} {{#if:{{{decrease3|}}}|<br />{{{decrease3}}}}} {{#if:{{{decrease4|}}}|<br />{{{decrease4}}}}}

I coded it, put it all together in the sandbox, at template:infobox NRHP/sandbox. And there are now two test cases (for 4 increases and for 4 decreases), now at the bottom of Template:Infobox NRHP/testcases. It all works.

Request: could this please be copied over to the template? --Doncram (talk,contribs) 04:36, 16 April 2023 (UTC)

 Completed. P.I. Ellsworth , ed. ^{put'er there} 10:40, 16 April 2023 (UTC)

Thanks. I see that you added to my suggested edit, to include the relevant parameters in the "check for unknown parameters" section further below my suggested changes.

That code starts out:

::{{#invoke:Check for unknown parameters|check|unknown={{main other|[[Category:Pages using infobox NRHP with unknown parameters|_VALUE_{{PAGENAME}}]]}}|preview=Page using [[Template:Infobox NRHP]] with unknown parameter "_VALUE_"|ignoreblank=y| added | alt | architect | architecture | area | borderless | builder | built | caption | coordinates | customarchitect_title | customarchitect | decrease | decrease_refnum | decrease1 | decrease1_refnum | ...

and continues...

and you added

| decrease4 | decrease4_refnum

and also added

| increase4 | increase4_refnum

into the sequence of "known parameters".

I wasn't aware of that part of the coding before, and see it makes sense. Thanks for doing that and for implementing the combined changes. --17:31, 17 April 2023 (UTC) Doncram (talk,contribs) 17:31, 17 April 2023 (UTC)

my pleasure, editor Doncram! More and more templates are including this test for unknown parameters. It only appears in preview, for example on the testcases page: when your section at Template:Infobox NRHP/testcases#include in "increase4=" coding is edited and then previewed (not saved), there is an error message that appears... Preview warning: Page using Template:Infobox NRHP with unknown parameter "1 = Late Victorian]], Late 19...". In that case it's because the argument in the |architecture= parameter contains

"..., Late Victorian architecture|Late Victorian]]," in its text.

Because the two opening brackets of that link are missing, the text after the pipe is seen by the software as an argument of the |1= parameter, and it throws the error.

Definitely helps editors who actually go looking for non-parameters in infoboxes, as well as editors who add non-parameters by mistake (as long as they preview their edit). Paine  23:25, 17 April 2023 (UTC)

Bug

Why does the "refnum" parameter accept links/templates like {{NaraStringOH}}, as seen at German Village, while "increase_refnum" won't? ɱ (talk) 17:31, 1 June 2023 (UTC)

Map has incorrect language settings

It has been noted at Wikipediocracy that the maps transcluded in this infobox that appear on articles about New York City properties have at least one label in Serbian rather than English: Central Park is labeled "Menhetn", presumably a designator for "Manhattan". See for example at Lucy Drexel Dahlgren House—Lucy Drexel Dahlgren House#/map/0, and The Ansonia—The_Ansonia#/map/0. The issue appears to be deeply embedded in the WMF maps: New York City#/map/0 has it too when one zooms in. Can someone with the necessary knowledge and access please fix this, and check that there are not other similar glitches? Yngvadottir (talk) 22:54, 9 December 2023 (UTC)

This appears to be T195318, a five-year-old bug. A previous report of this problem from 2021 is in the VPT archives. I don't know how it got fixed; I think something in the OpenStreetMap node label needed to be adjusted, – Jonesey95 (talk) 00:12, 10 December 2023 (UTC)

Thanks, that confirms my suspicions that the error is nested deep in the functions generating these maps :-( Although Heritage Plaza now shows the correct spelling of "Houston", the underlying problem with the "language picker" doesn't appear to have been fixed at all; the last thing I see at that Phabricator link is someone offering on November 9 to attempt a fix. Meanwhile, the VPT discussion leads to a different ticket, T230013, last edited June 2022. Yngvadottir (talk) 01:59, 10 December 2023 (UTC)

Category:Pages using Infobox NRHP in need of attention‎

Hi! Is Category:Pages using Infobox NRHP in need of attention‎ still being used by this template? I am not seeing it anywhere in the code, but I may be missing something. If not, I plan to take it to CfD for deletion. If so, I plan to take it to CfD for merging with Category:NRHP infobox needing cleanup. HouseBlaster^talk 21:03, 30 December 2023 (UTC)

The name of this category does not appear in any template code, so it should be safe to delete. It's not a great name, in any case. – Jonesey95 (talk) 02:26, 31 December 2023 (UTC)

Did some WikiBlame searching, it was never in any version of this template (or its subpages). I think it can/should be G8'd. Primefac (talk) 14:31, 31 December 2023 (UTC)

Template-protected edit request on 13 April 2024

For the "Location" field, please capitalize "bounded" (e.g., as in Fort Tryon Park: "bounded by 190th Street, Cabrini Boulevard[...]"), since it is the first word in the result. —DocWatson42 (talk) 11:47, 13 April 2024 (UTC) DocWatson42 (talk) 11:47, 13 April 2024 (UTC)

 Not done: That word is in the article, not in the template. – Jonesey95 (talk) 12:48, 13 April 2024 (UTC)

I'm sorry, and thank you. ^_^ —DocWatson42 (talk) 02:34, 14 April 2024 (UTC)