Template talk:GRIN

Errors found

@Oashi: The error check you just added has found three articles with errors:

• Anacampserotaceae
• Sudachi
• Tulipa schrenkii

Can you fix these? Thanks, Wbm1058 (talk) 15:48, 16 December 2014 (UTC)

I muddled through two of these, anyone is welcome to check my work. However, I believe I found an issue with Anacampserotaceae. I see that this template has a sister template {{GRIN genus}}. Perhaps another sister {{GRIN family}} should be created. The {{GRIN}} reference in Anacampserotaceae goes to:

• http://www.ars-grin.gov/cgi-bin/npgs/html/taxon.pl?2611

however, what I think may be intended is:

• http://www.ars-grin.gov/cgi-bin/npgs/html/family.pl?2611

This is really outside my area of competence. Wbm1058 (talk) 17:23, 20 January 2015 (UTC)

Update GRIN URL?

GRIN URLs of the template's form:
http://www.ars-grin.gov/cgi-bin/npgs/html/taxon.pl?<id>
currently redirect to the form
https://npgsweb.ars-grin.gov/gringlobal/taxonomydetail.aspx?id=<id>

So I'm wondering if the base URL needs to be updated to the new form. Not urgently as I'm sure the redirect will work for some time. But perhaps not indefinitely. Thanks Declangi (talk) 02:54, 8 March 2016 (UTC)

@Declangi: I have updated the template to use a more up-to-date HTTPS URL. This change should reduce the number of HTTP redirects and provide increased privacy and security for users. --Elegie (talk) 09:37, 13 May 2017 (UTC)

@Elegie: Looks great, thanks for updating this. Declangi (talk) 09:33, 14 May 2017 (UTC)

Species italics when by ID only

If I use the template with ID only, e.g. {{GRIN | 405245}}, I get a result with the species name, which is fine. But it would be great if the species were italicised, as for e.g. {{WCSP | 405245}}. Many thanks if easily doable. Declangi (talk) 20:59, 4 August 2017 (UTC)

Hello again @Elegie: I now realise that you may not have this template on your watchlist. I'm just wondering what you think of the above change regarding italics. This would also apply to the concise form without an ID, e.g. {{GRIN}}, sufficient for many articles. I've been updating direct GRIN URLs to use this template and in the cases of using the concise forms of the template it would be nice to have italics output for species names. Many thanks again, Declangi (talk) 09:27, 11 January 2018 (UTC)

Many thanks Elegie, I've tried out the updated template and things now look great. Declangi (talk) 10:42, 16 January 2018 (UTC)

The handling of the |name= parameter

What is the if-statement that determines whether the |name= parameter is displayed meant to do? It takes the value of the |name= parameter (or the id in parameter 1), and then checks whether the value converted to a number plus 3 is less than the length of the value; if so, the value is displayed as the link text. So if I use |name=''Andromeda polifolia'' L. var. ''latifolia'' Aiton, its length is 51, but its number value is 0, so it is not displayed. I don't know why that would be desirable. I would make an edit request to fix this, but I have no idea what the if-statement is meant to do, so I don't know how to change it to make it work properly. — Eru·tuon 17:22, 18 July 2018 (UTC)

Template-protected edit request on 4 September 2019

Recently, a warning appears when using this template (or viewing the template page itself), regarding mode = CS1. I believe using lowercase will fix it:
| mode = {{{mode|cs1}}}

Declangi (talk) 09:59, 4 September 2019 (UTC)

I confirmed in another template that lower-case solves the warning. Another option would be to change the module to accept upper-case, I raised that question, but don't let that stop this edit request. JAGulin (talk) 11:31, 4 September 2019 (UTC)

 Done – Jonesey95 (talk) 17:39, 4 September 2019 (UTC)

Code and documentation do not match.

Adding {{GRIN}} to the Iris lortetii page creates the following:

"Iris lortetii". Germplasm Resources Information Network. Agricultural Research Service, United States Department of Agriculture.

NOT:

"Iris lortetii". Germplasm Resources Information Network (GRIN).

Something (code and/or documentation, should be both) needs to change. I agree that "Cite as: USDA, Agricultural Research Service, National Plant Germplasm System. 2019. Germplasm Resources Information Network (GRIN-Taxonomy). National Germplasm Resources Laboratory, Beltsville, Maryland. URL: https://npgsweb.ars-grin.gov/gringlobal/taxonomydetail.aspx?id=20350. Accessed 7 November 2019." is ridiculous, but it provides a start. Cite should have the name/title and it should link to the web page. The ARS and USDA links may be fluff. -- User-duck (talk) 00:13, 8 November 2019 (UTC)

@User-duck: Probably resolved, please see my note in thread #Doc file is obsolete below. --CiaPan (talk) 07:36, 27 January 2020 (UTC)

GRIN is not a grin

Please add a noinclude-d hatnote with a message like

The Template:grin redirects here; for a smiley see {{=D}} or {{Smiley}}.

CiaPan (talk) 10:06, 31 December 2019 (UTC)

 Done: I hope editors realize this is a noinclude hatnote. — hike395 (talk) 07:48, 27 January 2020 (UTC)

@Hike395: Thank you. And I hope so. I suppose editors experienced enough to use the template are also experienced enough to verify the supposed result with preview, if in doubt. Anyway, if I am wrong and the change will make the template use harder instead of easier, feel free to revert it. --CiaPan (talk) 20:11, 27 January 2020 (UTC)

Doc file is obsolete

Section Template:GRIN/doc#Syntax, the Example says:

Adding {{GRIN}} to the Maize page creates the following:   "Maize". Germplasm Resources Information Network (GRIN).

whilst it actually creates something close to

"Zea mays". Germplasm Resources Information Network (GRIN). Agricultural Research Service (ARS), United States Department of Agriculture (USDA).

CiaPan (talk) 07:13, 2 January 2020 (UTC)

 Done Did it myself, hopefully didn't break it. --CiaPan (talk) 07:35, 27 January 2020 (UTC)

Builds incorrect url

The GRIN template appears to be building an incorrect url. The examples on the template documentation page, when clicked, go to a blank GRIN page.

Example, click on this:

• https://npgsweb.ars-grin.gov/gringlobal/taxonomydetail.aspx?3074

However, on the GRIN website, if you search for the taxon (Anasus comosus) and click in the result you want (the first in the list), you are sent to this URL:

• https://npgsweb.ars-grin.gov/gringlobal/taxon/taxonomydetail?id=3074.

current  GRIN template URL: https://npgsweb.ars-grin.gov/gringlobal/taxonomydetail.aspx?3074
proposed GRIN template URL: https://npgsweb.ars-grin.gov/gringlobal/taxon/taxonomydetail?id=3074

The .aspx has been removed, an id= has been added, and a /taxon now exists before the taxonomydetail.

The documentation page will need to be corrected as well. I don't have the knowledge on how to do templates, only to report what appears to be bugs in them. --Eewilson (talk) 17:46, 3 February 2021 (UTC)

Add info for ability to use shortened footnotes?

Can someone modify this template enable the ability to use sfn? Ideally, to be able to be used as

{{sfn|GRIN|<<year>>}}

. Or something like that. Thanks. —Eewilson (talk) 03:47, 26 July 2021 (UTC)

GRIN URL format change

It looks like they have updated their URL format again, without redirecting. Our current template format:

https://npgsweb.ars-grin.gov/gringlobal/taxonomydetail.aspx?id=1234

Their new format:

https://npgsweb.ars-grin.gov/gringlobal/taxon/taxonomydetail?id=1234

It looks like they have dropped the .aspx part of the URL and added a /taxon component. Thanks, Declangi (talk) 22:52, 16 September 2022 (UTC)