Template talk:Remove file prefix

Latest comment: 1 year ago by Gonnym in topic Edit request May 2022

Edit request May 2022 edit

Replace code with

{{PAGENAME:{{{1|}}}}}

It's simpler and more efficient, and acts identically to this much more complicated code.

INPUT:

{{PAGENAME:File:Foo.jpg}}

OUTPUT:

Foo.jpg


INPUT:

{{PAGENAME:Foo.jpg}}

OUTPUT:

Foo.jpg

The only reason not to do this is if the Other:Foo.jpg is a desirable returnstate, which, again, can be done with standard template code. Adam Cuerden (talk)Has about 7.8% of all FPs 18:23, 10 May 2022 (UTC)Reply

Tests from doc edit

  • Example.svg → Example.svg
    • →Example.svg
  • Example.svg → Example.svg
    • →Example.svg
  • Example.svg → Example.svg
    • →Example.svg
  • Example.svg → Example.svg
    • →Example.svg
  • Example.svg → Example.svg
    • →Example.svg
  • Other:Example.svg → Other:Example.svg
    • →Other:Example.svg
xaosflux Talk 18:40, 10 May 2022 (UTC)Reply


It should be noted that this page, as written, doesn't remove other namespaces, while {{PAGENAME}} will:

  • Example.svg
    • Example.svg
  • Example.svg
    • Example.svg

I can't see any cases where this will matter, and it's arguably undocumented behaviour for this template, but it's worth noting. Adam Cuerden (talk)Has about 7.8% of all FPs 19:09, 10 May 2022 (UTC)Reply

About 15 templates use it, [1], probably if that's all this template actually does, it should just be replaced with the magic word in those cases and deleted. Galobtter (pingó mió) 01:54, 11 May 2022 (UTC)Reply
Yeah,I checked all 15 uses, and they're literally all just using some variant of File:{{Remove file prefix|{{{image|}}}}} or the same, but one step removed (like passing it to an image layout template or module). That's a good way to standardise inputs, but the magic word can do that no problem. Adam Cuerden (talk)Has about 7.8% of all FPs 04:21, 11 May 2022 (UTC)Reply
FYI: Going slow on this because it has main page links. — xaosflux Talk 13:15, 11 May 2022 (UTC)Reply
...That would be an excellent reason, aye. Better safe than sorry Adam Cuerden (talk)Has about 7.8% of all FPs 15:07, 11 May 2022 (UTC)Reply
15 transclusions replaced. Let me know if you see any issues — Martin (MSGJ · talk) 12:09, 27 May 2022 (UTC)Reply
It appears that some change made in relation to this discussion may have broken the sidebar at List of proclamations by Donald Trump (2018). Can someone please take a look? – Jonesey95 (talk) 15:19, 27 May 2022 (UTC)Reply
It was caused by {{!}} to provide alt text [2] — Martin (MSGJ · talk) 15:25, 27 May 2022 (UTC)Reply

With no further error reports, seems like this is resolved. The remaining transclusions are direct uses of this template, mainly on talk pages — Martin (MSGJ · talk) 09:51, 3 June 2022 (UTC)Reply

Seems some (most? all?) are from old subst copies of Template:UpcomingPOTD which left horrible code like [[:File:{{Remove file prefix|VAN BUREN, Martin-President (BEP engraved portrait).jpg}}]] at Talk:Martin Van Buren. Gonnym (talk) 19:27, 9 June 2022 (UTC)Reply