MediaWiki talk:Gadget-afchelper.js

Revert changes

Someone went overboard trying to fix a bug and pushed several changes without going through our GitHub repo. Please revert to this revision. Thanks, Nathan2055^{talk - contribs} 15:36, 7 July 2013 (UTC)

Already done It looks like Martijn Hoekstra has already reverted, but to the 1 July version rather than the version you linked to. Please reactivate this request if having that version is important. Best — Mr. Stradivarius ^{♪ talk ♪} 10:21, 8 July 2013 (UTC)

Edit Protected request October 2, 2013

Whomever can get to this first (Huon—Armbrust—Legoktm), please replace:

	$("#bodyContent [sectionIndex]").click((function() {
		$("#bodyContent [sectionIndex]").each(function(i) {
			$(reviewlink).html("Reviewing requests...");
		});
		afcHelper_ffu_init();
	}));

With this:

	$( "#bodyContent [sectionIndex]" ).click((function() {
		$( "#bodyContent [sectionIndex]" ).each(function(i) {
			$( this ).html( "Reviewing requests..." );
		});
		afcHelper_ffu_init();
	}));

On or near line 412. Thank you. Technical 13 (talk) 18:36, 2 October 2013 (UTC)

Done. Huon (talk) 18:54, 2 October 2013 (UTC)

Protected edit request on 5 May 2014

(@Legoktm and Soap:) Please append all of the code at [1] to the bottoms of MediaWiki:Gadget-afchelper.js/core.js and MediaWiki:Gadget-afchelper-beta.js/core.js. This implements whitelist-checking per the decision at Wikipedia:WikiProject Articles for creation/RfC for AfC reviewer permission implementation (see also: request).

Thanks, Theopolisme (talk) 22:08, 5 May 2014 (UTC)

OK I put it in there, please let me know if I did anything wrong. —Soap— 00:01, 6 May 2014 (UTC)

"AFCH error" box

A feature of this gadget is currently discussed at Wikipedia:Village pump (technical)/Archive 126#"AFCH error" box. PrimeHunter (talk) 00:01, 7 May 2014 (UTC)

Redirects.js

A bug in the live version of the MediaWiki:Gadget-afchelper.js/redirects.js script (misplaced brace) was reported on a user's talk page and caught my attention through the placement of a Helpme template. As such, I've done some testing and MediaWiki:Gadget-afchelper-beta.js/redirects.js seems to be working. Please push that version of this part of the script forward to live to fix the issue. Thank you. — {{U|Technical 13}} ^{(e • t • c)} 19:18, 28 June 2014 (UTC)

 Done Huon (talk) 16:11, 29 June 2014 (UTC)

• Thanks Huon. The script runs now, but it doesn't "do" anything persay... The change apparently relies on other changes in beta, and I'll have to do some further testing to figure out what else has to be moved. Either way, it's progress and there's no harm leaving it as is until I figure out what needs to be copied.  :) — {{U|Technical 13}} ^{(e • t • c)} 16:28, 29 June 2014 (UTC)

There's a lot of jQuerification in the update for /core.js and a couple new functions added. As there have been no complaints about beta, and I know it is working properly based on my own usage... @Legoktm and Earwig: can one of you push all of beta to live? This should fix the remaining issues. Thanks. — {{U|Technical 13}} ^{(e • t • c)} 16:35, 29 June 2014 (UTC)

Protected edit request on 11 July 2014

See also: WP:Village pump (technical) § No more "wg..." globals in JavaScript

Could someone make these changes to the script? Helder.wiki 21:13, 11 July 2014 (UTC) Helder.wiki 21:13, 11 July 2014 (UTC)

Or just push the beta script to live like I requested two weeks ago? — {{U|Technical 13}} ^{(e • t • c)} 21:16, 11 July 2014 (UTC)

 Done — Martin (MSGJ · talk) 11:49, 24 July 2014 (UTC)

Protected edit request on 8 November 2014

(Main AFCH dev here – I was taking a wikibreak when the changes I discuss were enacted, hence why I did not raise my concerns earlier.)

@MSGJ, who implemented the original switch to the rewrite script following consensus: Currently, this script follows quite a convoluted path to ultimately load the rewritten helper script (found at User:Theopolisme/afch-rewrite.js). Long story short, a subscript is loaded, which is actually just copy-and-pasted from the script in userspace, but then just calls the script in userspace after all... this is not efficient! tl;dr, please update MediaWiki:Gadget-afchelper.js to contain solely the following content, which just directly loads the script if the page is AfC-applicable, without any strange twists and turns:

///////////////////////////////////////////////
//////// Yet Another AfC Helper Script ////////
//// https://en.wikipedia.org/wiki/WP:AFCH ////
//// https://github.com/WPAFC/afch-rewrite ////
///////////////////////////////////////////////

( function ( mw, importScript ) {
	if ( /^(?:User:|Draft:|Wikipedia(?:_talk)?:Articles_for_creation)/.test( mw.config.get( 'wgPageName' ) ) ) {
		importScript( 'User:Theopolisme/afch-rewrite.js' );
	}
}( mediaWiki, importScript ) );

This change should not be apparent to the end user (aside from a slightly faster load time, perhaps). Thanks! Please let me know if you have any questions. Theopolisme (talk) 14:10, 8 November 2014 (UTC)

Done — Mr. Stradivarius ^{♪ talk ♪} 15:48, 8 November 2014 (UTC)

Thanks! I appreciate your help. Theopolisme (talk) 16:34, 8 November 2014 (UTC)

Protected edit request on 21 February 2016

Due to Theopolisme's current inactivity, I'd like the importScript( 'User:Theopolisme/afch-rewrite.js' ); call to be changed to point to the version of the master branch I have in my userspace, which I'll frequently update to keep up with the latest version on GitHub. The revised call will read importScript( 'User:APerson/afch-master.js' );. (Note that this is a new set of subpages I've just created, separate from the afch-dev code I already had there.) This will have the effect of enabling the last few features I've been testing, which include decline reason previews and additional comments on author talk pages. APerson (talk!) 20:55, 21 February 2016 (UTC)

Done — Martin (MSGJ · talk) 14:46, 22 February 2016 (UTC)

Thanks! APerson (talk!) 14:59, 22 February 2016 (UTC)

Protected edit request on 29 May 2016

Please change "APerson" to "Enterprisey", due to my recent rename. Enterprisey (talk!) _{(formerly APerson)} 15:27, 29 May 2016 (UTC)

 Done — xaosflux ^Talk 18:19, 29 May 2016 (UTC)

Protected edit request on 16 April 2017

wgPageName and importScriptURI are depreciated. MediaWiki:Gadget-afchelper-beta.js should use mw.config.get('wgServer') and mw.loader.load instead. I have mocked this up at User:Ahecht/sandbox/Gadget-afchelper-beta.js (pinging Legoktm). --Ahecht (TALK
PAGE) 05:15, 16 April 2017 (UTC) Ahecht (TALKReply
PAGE) 05:15, 16 April 2017 (UTC)

Done — Martin (MSGJ · talk) 07:34, 20 April 2017 (UTC)

Protected edit request on 31 July 2018

As suggested by Amorymeltzer at my talk page, please change the if statement line to add an additional check that the user isn't on WP:AFC/R. The original line:

if ( /^(?:User:|Draft:|Wikipedia(?:_talk)?:Articles_for_creation)/.test( mw.config.get( 'wgPageName' ) ) ) {

would be replaced by these two lines:

if ( /^(?:User:|Draft:|Wikipedia(?:_talk)?:Articles_for_creation)/.test( mw.config.get( 'wgPageName' ) ) &&
        mw.config.get('wgPageName') !== 'Wikipedia:Articles_for_creation/Redirects' ) {

Enterprisey (talk!) 19:46, 31 July 2018 (UTC)

 Done Thanks! Link to request for posterity. ~ Amory (u • t • c) 22:38, 31 July 2018 (UTC)

Interface-protected edit request on 1 April 2021

Please put <nowiki>...</nowiki> somewhere around the {{_foo}}{{/foo}} in the comment near line 558 in MediaWiki:Gadget-afchelper.js/core.js to fix this link in Special:WantedTemplates. Or whatever else works to fix the issue. Thanks! Plastikspork _―Œ^(talk) 13:40, 1 April 2021 (UTC)

@Enterprisey: Plastikspork _―Œ^(talk) 13:41, 1 April 2021 (UTC)

 Done Writ Keeper ⚇♔ 15:14, 16 April 2021 (UTC)

Edit request to complete MfD nomination

MediaWiki:Gadget-afchelper.js/core.js has been listed at Miscellany for deletion (nomination), but it was protected, so it could not be tagged. Please add:

/* {{mfd|help=off}} */

to the top of the page to complete the nomination. Thank you. — Alexis Jazz (talk or ping me) 15:34, 14 January 2022 (UTC)

 Done — xaosflux ^Talk 17:37, 14 January 2022 (UTC)

Interface-protected edit request on 17 January 2022

Please remove the MfD tag since the discussion was closed as keep. * Pppery * _{it has begun...} 00:43, 17 January 2022 (UTC)

 Done — xaosflux ^Talk 02:01, 17 January 2022 (UTC)

Interface-protected edit request on 2 February 2022

Could someone move the <nowiki> in the comments on line 578 to somewhere before line 552 in MediaWiki:Gadget-afchelper.js/core.js (e.g. to near the top like we have in MediaWiki:Gadget-afchelper.js)? There is already a </nowiki> at the bottom :) I am trying to reduce the number of false positives in Special:WantedTemplates, and that page is transcluding Template:/foo. Note that this was already done back in April but probably was overwritten by subsequent changes. Thank You! Plastikspork _―Œ^(talk) 23:41, 2 February 2022 (UTC)

When I have a moment, I'm gonna make this change on GitHub so it'll propagate over. Enterprisey (talk!) 23:43, 2 February 2022 (UTC)

 Done @Plastikspork: it looks like there is an "unmatched" nowiki embeded in line 942 too; all in commetns so the script doesn't care. — xaosflux ^Talk 14:59, 9 February 2022 (UTC)

@Plastikspork I've fixed the issue in the script code so the change should be permanent from now on. Can you verify that the issue is currently fixed on your end? Enterprisey (talk!) 22:05, 16 February 2022 (UTC)

I don't see it generating any links to Template:/foo, so that works for me. Thanks! Plastikspork _―Œ^(talk) 14:46, 17 February 2022 (UTC)