MediaWiki talk:Gadget-ReferenceTooltips.js

Latest comment: 3 months ago by Pppery in topic Change 2 strings
Note: There is also discussion at User talk:Yair rand/ReferenceTooltips

Sync edit

Could an admin please re-copy User:Yair rand/ReferenceTooltips.js to this page to add the recent bug fix? Thanks. --Yair rand (talk) 19:19, 4 April 2012 (UTC)Reply

Done.  Sandstein  17:27, 11 April 2012 (UTC)Reply

Could someone synchronize the pages again, please? --Yair rand (talk) 21:35, 19 April 2012 (UTC)Reply

  Done --Redrose64 (talk) 22:15, 19 April 2012 (UTC)Reply
Thank you. --Yair rand (talk) 22:25, 19 April 2012 (UTC)Reply
I've made some changes to User:Yair rand/ReferenceTooltips.js and User:Yair rand/ReferenceTooltips.css, to add a delay to the tooltip, functionality for touch screens, and a settings menu including options to change both and a disable button. Could someone please copy them over MediaWiki:Gadget-ReferenceTooltips.js and MediaWiki:Gadget-ReferenceTooltips.css, respectively? Thanks. --Yair rand (talk) 03:05, 11 June 2012 (UTC)Reply
  okay — Martin (MSGJ · talk) 17:19, 11 June 2012 (UTC)Reply

Hm edit

Where is element #footer-places? Also, disabling of this gadget isn't work (Firefox 13). Saint Johann (ru) 15:48, 17 June 2012 (UTC)Reply

#footer-places is at the bottom of the page, holding the "Privacy policy", "About Wikipedia", and "Disclaimers" links, but only in Vector skin. I had forgotten to also include the equivalent elements for other skins. There was also another bug in working with other skins that I had missed. Now that both bugs, as well as the problem in Firefox, are fixed, could an admin please copy User:Yair rand/ReferenceTooltips.js and User:Yair rand/ReferenceTooltips.css over MediaWiki:Gadget-ReferenceTooltips.js and MediaWiki:Gadget-ReferenceTooltips.css again? (Sorry for having to ask so frequently.) --Yair rand (talk) 19:52, 17 June 2012 (UTC)Reply
  Done --Redrose64 (talk) 20:08, 17 June 2012 (UTC)Reply
Thanks. --Yair rand (talk) 20:13, 17 June 2012 (UTC)Reply
MediaWiki:Gadget-ReferenceTooltips.js and MediaWiki:Gadget-ReferenceTooltips.css need yet another sync, to fix this bug. Thanks. --Yair rand (talk) 21:06, 2 July 2012 (UTC)Reply
  Done --Redrose64 (talk) 22:33, 2 July 2012 (UTC)Reply
Sorry, I made a mistake in the edit to User:Yair rand/ReferenceTooltips.js. Could someone please re-sync the pages to fix this? Sorry about that. --Yair rand (talk) 00:03, 3 July 2012 (UTC)Reply
Done. Thank you. Rjd0060 (talk) 02:29, 3 July 2012 (UTC)Reply
There was a bug with the script working with iPads, hopefully the recent change to User:Yair rand/ReferenceTooltips.js fixes it. Could an admin sync the gadget page again, please? --Yair rand (talk) 04:56, 5 July 2012 (UTC)Reply
  Done --Redrose64 (talk) 10:26, 5 July 2012 (UTC)Reply
Could someone please sync this with User:Yair rand/ReferenceTooltips.js again? Thanks. --Yair rand (talk) 23:40, 21 August 2012 (UTC)Reply
  Done --Redrose64 (talk) 16:13, 22 August 2012 (UTC)Reply

Protected edit request on 11 July 2014 edit

Hello!

Could someone apply these changes to the script? Helder.wiki 21:22, 11 July 2014 (UTC)Reply

  Done Ruslik_Zero 19:43, 18 July 2014 (UTC)Reply

NotFoundError edit

This gadget causes the error: NotFoundError: Node was not found. See phab:T109486. Helder 17:54, 18 August 2015 (UTC)Reply

@He7d3r: Checked Chrome/FF/IE on Window 7, could not reproduce. What browser were you using? --Yair rand (talk) 18:09, 18 August 2015 (UTC)Reply

I was using Iceweasel 38.2.0. On Google Chrome it is a little more verbose:

{
	"errorMessage": "Uncaught NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.",
	"url": "https://en.wikipedia.org/wiki/%28%CE%B5,_%CE%B4%29-definition_of_limit",
	"lineNumber": 102,
	"columnNumber": 812,
	"errorObject": {
		"stack": "Error: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.\n    at Error (native)\n    at HTMLUListElement.eval (eval at <anonymous> (https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=3hR%2F0Nym:4:681), <anonymous>:102:812)\n    at HTMLUListElement.opt.complete (https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=3hR%2F0Nym:110:60)\n    at fire (https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=3hR%2F0Nym:45:124)\n    at Object.self.fireWith [as resolveWith] (https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=3hR%2F0Nym:46:431)\n    at Animation.tick (https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=3hR%2F0Nym:107:719)\n    at jQuery.fx.tick (https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=3hR%2F0Nym:112:760)"
	}
}

Helder 18:55, 18 August 2015 (UTC)Reply

PS: it also happens when I'm not logged in. Helder 18:56, 18 August 2015 (UTC)Reply

Formatting by stylesheet edit

To allow users to use custom styling of the highlighted reference, please replace:

  1. h.style.border = ""$( h ).removeClass("RTTarget")
  2. h.style.border = "#080086 2px solid"$( h ).addClass("RTTarget")

Note that this class is already defined in MediaWiki:Gadget-ReferenceTooltips.css. Petr Matas 14:44, 9 January 2016 (UTC)Reply

Hm, this was actually in the changes that I made to the version in my userspace, but I never ended up requesting a merge, and I can't remember why... Eh. --Yair rand (talk) 04:08, 11 January 2016 (UTC)Reply
  DoneMr. Stradivarius ♪ talk ♪ 07:25, 13 January 2016 (UTC)Reply

Tooltip is not shown if the reference is above the visible area edit

Problem description: Open Quantum state#Ref-14. Reference 14 contains a link to reference 1. If you hover on the link to reference 1, no tooltip is shown, although reference 1 is off-screen (above the visible area). This is because the check for the reference being below the visible area is implemented, but above is not.

Fix: Please replace

if( !isTouchscreen && ( window.pageYOffset || document.documentElement.scrollTop || document.body.scrollTop || 0 ) + $(window).height() > $( h ).offset().top + h.offsetHeight ) {

with

var windowTop = window.pageYOffset || document.documentElement.scrollTop || document.body.scrollTop || 0;
if( !isTouchscreen && windowTop < $( h ).offset().top && windowTop + $(window).height() > $( h ).offset().top + h.offsetHeight ) {

Petr Matas 13:20, 13 January 2016 (UTC)Reply

Probably easier if you dump the whole code in a sandbox next time, so I can just copy/paste. But   Done — Martin (MSGJ · talk) 09:25, 14 January 2016 (UTC)Reply
Ok, thanks :) Petr Matas 12:00, 14 January 2016 (UTC)Reply

Sync request edit

Could an admin please merge these changes? Changes include:

  • Nested references can have tooltips.
  • Links inside reference tooltips are compatible with hovercards, for those who have the beta feature enabled.
  • Messages are grouped at the top and use mw.msg, for easier localization when imported to other language projects.
  • Reference Tooltips now runs in the Draft namespace.
  • Minor general cleanup.

--Yair rand (talk) 23:04, 14 January 2016 (UTC)Reply

  Done — Martin (MSGJ · talk) 09:24, 15 January 2016 (UTC)Reply

jQuery 3 edit

This script contains the lines

$(this)[ isTouchscreen ? 'click' : 'hover' ](function( e ){

and

isTouchscreen || $(tooltipNode).hover(show, hide);

which cause the following warning in the console:

JQMIGRATE: jQuery.fn.hover() is deprecated

Helder 22:54, 7 October 2017 (UTC)Reply

  Not done: it's not clear what changes you want to be made. Please mention the specific changes in a "change X to Y" format. — Martin (MSGJ · talk) 07:13, 27 October 2017 (UTC)Reply
This was resolved by KrinkleTheDJ (talkcontribs) 12:38, 1 November 2017 (UTC)Reply

Update suggestion edit

 

Hello! I would like to suggest to update to the new version of this gadget I've presented at mw:Topic:Ueqlcc482l9yw8gv. There are numerous bugfixes and added features like Harvard-style citations support. Tooltip style & animations are also updated to be consistent with Page Previews' style & animations. It has been tested thoroughly and used in Russian Wikipedia for several months with no complaints.

Jack who built the house (talk) 11:18, 29 December 2018 (UTC)Reply

  DoneTheDJ (talkcontribs) 16:40, 2 February 2019 (UTC)Reply
P.S. you might want to get rid of the cookies in favor of LocalStorage. That helps reduce request size and we won't be bothering the WMF servers with that info any longer. —TheDJ (talkcontribs) 16:43, 2 February 2019 (UTC)Reply
Per phab:T179415 for logged in users it should really be replaced with toggling the gadget in preferences. Galobtter (pingó mió) 07:35, 8 February 2019 (UTC)Reply
@TheDJ: Thanks! I forgot: jquery.client and mediawiki.notify dependencies are needed too. Jack who built the house (talk) 19:52, 2 February 2019 (UTC)Reply
  • Hello Jack, nice to see you here. My two cents: since I'm sill using Opera 12.18, I was afraid that your new version would not work for me, as for some unknown reason on ruwiki it didn't, but oddly enough that's not the case now, it does work. (Except for the absence of icon in the upper right corner, but that's bearable.) So take my congrats on the success. — Mike Novikoff 02:33, 3 February 2019 (UTC)Reply

Mechanics edit

@Jack who built the house: to be clear, is this ready to go and you would like us to replace:
? — xaosflux Talk 13:52, 9 January 2019 (UTC)Reply
Yes, that's correct. Right now I have both of these files in my common.js, and it's working properly. Jack who built the house (talk) 14:18, 9 January 2019 (UTC)Reply
@Xaosflux. Jack who built the house (talk) 14:20, 9 January 2019 (UTC)Reply
@Xaosflux: Hello! Any updates? Jack who built the house (talk) 14:58, 11 January 2019 (UTC)Reply
  • Seems like a good idea.... << FR 10:09, 12 January 2019 (UTC)Reply
  • Pinging MSGJ, who helped with several prior change requests. Would you be able to merge the above changes? --Yair rand (talk) 06:12, 15 January 2019 (UTC)Reply

Interference with links on touchscreen edit

As reported here, this gadget's feature to show tooltips seems to make links with tooltips unclickable on touchscreen devices:

This is particularly inconvenient on navboxes, which uses {{navbar|mini=y}} to show the links on top left. Can this be fixed with a change to this JS? Nardog (talk) 09:50, 4 April 2019 (UTC)Reply

We also have this problem in Ukrainian Wiki after we updated Gadget:Reference Tooltips to the last version. I think it would be the best solution if the words “view this template”, “discuss…” and “edit…” became pressable after you click on vte. If anyone can fix the bug in this way, please do this! --Gzhegozh (talk) 12:35, 5 April 2019 (UTC)Reply
@TheDJ: I am sorry to bother you, but maybe you can help fix the problem? --Gzhegozh (talk) 15:45, 7 April 2019 (UTC)Reply

I fixed the issue together with another one, reported at en:Template talk:Harvard citation#Cosmetic issue: nested quotes.

Please update the gadget by moving the code from en:User:Jack who built the house/Gadget-referenceTooltips.js to here.

@Gzhegozh: you can update in your wiki too. Jack who built the house (talk) 14:00, 10 May 2019 (UTC)Reply

@Jack who built the house: just want to make sure that this is the change you are asking for: DIFF. — xaosflux Talk 19:25, 10 May 2019 (UTC)Reply
Yes, I only forgot the comment on top: // Source https://en.wikipedia.org/wiki/MediaWiki:Gadget-ReferenceTooltips.js. Updated my code, now it's correct. Jack who built the house (talk) 19:32, 10 May 2019 (UTC)Reply
Xaosflux Jack who built the house (talk) 19:33, 10 May 2019 (UTC)Reply
  Done. ~Oshwah~(talk) (contribs) 10:21, 11 May 2019 (UTC)Reply

Add support for directionality of ref tags edit

Since May 2018 we have the ability to use the dir attribute in the <ref> tags to specify the directionality of ref tags as right-to-left (RTL) or left-to-right (LTR). This is widely used in pages that cite both RTL and LTR sources, for example on Persian Wikipedia (fawiki, see example). Since the ReferenceTooltips code is used on many wikis, it is ideal to add support for directionality in its enwiki version so that all others who copy it would also benefit from it.

I have already implemented the solution into our copy on fawiki. Please incorporate it here too.

Happy to answer any questions (but please {{ping}} me). hujiTALK 14:47, 1 July 2019 (UTC)Reply

@Huji: (Presumably you did not mean to leave in the console.log there.) --Yair rand (talk) 16:40, 1 July 2019 (UTC)Reply
@Yair rand: correct; I updated the diff link above hujiTALK 16:46, 1 July 2019 (UTC)Reply
The structure of the surrounding code context appears to be substantially different in enwiki's version of this script; I'm not sure it would be a straightforward cut-and-paste. Writ Keeper  14:54, 2 July 2019 (UTC)Reply
  Not done this would need to be thoroughly tested here first, feel free to mock it up as a user script here on wiki and gain some testers. — xaosflux Talk 19:50, 15 July 2019 (UTC)Reply

Feature suggestion: support for book references edit

The Cite extension has an experimental feature called book referencing. This feature allows editors to cite multiple parts of an already-cited source using the extends attribute. For instance, an editor could cite a book with the citation <ref name="Miller">E. Miller, ''The Sun'', (New York: Academic Press, 2005)</ref>, and then they could cite page 42 in that book with a second citation <ref extends="Miller">p. 42</ref>.

Continuing with the earlier example, currently when a user hovers over the "p. 42" sub-citation, the tooltip will just contain "p. 42" without the book name. That tooltip is not especially useful. It would be nice if this gadget could handle "book references" more naturally. That is, if a user hovers over a citation of the form <ref name="child" extends="parent">text</ref> attribute, it would be nice if the tooltip displayed the contents of both the parent and child citations. Note that book citations can only go one level deep (you cannot extend a citation that extends another citation), which should make the implementation more straightforward. Thank you for considering this suggestion! MtMNC (talk) 06:51, 2 November 2020 (UTC)Reply

The feature in Cite extension was experimental. The project was eventually abandoned unfortunately, see m:WMDE Technical Wishes/Book referencing. – SD0001 (talk) 07:23, 14 December 2021 (UTC)Reply

Change 2 strings edit

As it turned out, it can be unclear to users what they are disabling/enabling. So please replace

	'rt-enable': 'Enable',
	'rt-disable': 'Disable',

with

	'rt-enable': 'Enable Reference Tooltips',
	'rt-disable': 'Disable Reference Tooltips',

Jack who built the house (talk) 20:43, 4 February 2024 (UTC)Reply

  Done * Pppery * it has begun... 21:34, 4 February 2024 (UTC)Reply