MediaWiki talk:DYK-nomination-wizard.js

MediaWiki namespace move

Please move this page to MediaWiki:DYK-nomination-wizard.js, so that it can be loaded by URL. See discussions: Wikipedia:Village pump (technical)/Archive 193#Proposal to turn the DYK helper into a gadget and Wikipedia talk:Did you know#DYK-helper script improvements and auto-loading.

Also, please apply some protection on Wikipedia:Did you know/Create new nomination – the page from which the script is invoked. ECP should be fine. – SD0001 (talk) 11:37, 3 November 2021 (UTC)

 Done, although I upped the protection level to TE after reflection, since it looks like ECP is still only authorized in specific fields. Writ Keeper ⚇♔ 16:46, 20 November 2021 (UTC)

hlist moving from Common.css

At some point in the nearer rather than further future, .hlist styles will be removed from Common.css and Mobile.css in favor of TemplateStyles. This is a headsup to adjust what this script is doing. The replacement is at Template:Hlist/styles.css in case you wish to load the sheet in JavaScript instead. cc @SD0001 Izno (talk) 03:39, 24 December 2022 (UTC)

please sync with User:SD0001/DYK-helper/withJsMode2.js (diff). This replaces use of .hlist with a hand-made bulleted list. cc @Izno. – SD0001 (talk) 05:20, 24 December 2022 (UTC)

 Done Izno (talk) 05:23, 24 December 2022 (UTC)

Interface-protected edit request on 21 March 2024

Please sync the changes from User:SD0001/DYK-helper/withJsMode2.js (diff). The following change(s) have been done:

• Now shows the number of QPQs required in the interface, based on count of user's past nominations and whether the backlog mode is active.

– SD0001 (talk) 11:21, 21 March 2024 (UTC)

 Done, noting this creates a dependency on User:SDZeroBot/DYK nomination counts.json. — xaosflux ^Talk 13:24, 21 March 2024 (UTC)

Interface-protected edit request on 24 March 2024

Please sync the changes from User:SD0001/DYK-helper/withJsMode2.js (diff). The following change(s) have been done:

• Improve performance by not loading the big page User:SDZeroBot/DYK nomination counts.json on the client. Instead do it on the server by invoking a lua function in Module:NewDYKnomination. The module only being semi-protected is not a problem as only two numeric outputs from it are used. We also validate that they are numeric.

– SD0001 (talk) 17:55, 24 March 2024 (UTC)

 Done * Pppery * _{it has begun...} 00:48, 31 March 2024 (UTC)

Interface-protected edit request on 4 April 2024

Please change:

' <small>Source: ' + params.source + '</small>'

To:

'\n{{smalldiv|1= \n* Source: ' + params.source + '}}'

The intent is to add a new line and then wrap the "Source" portion in div tags. When someone puts a multi-line block of text into the "Source" field using the existing code, it creates Linter errors of a type that have been cleared from Template space (loosely related: what ever happened to moving DYK to Wikipedia space, where it belongs?). Here's a sample change that Lint-error-fixing gnomes need to make a few times per day.

I think that this change will work from a technical standpoint, but it may not be exactly the formatting that people want. It would be easier to just remove the small formatting entirely, but I don't know if people will go for that either. – Jonesey95 (talk) 23:20, 4 April 2024 (UTC)

@Jonesey95 In looking at the example before and after: frankly, the bulleted list layout is really a garbage fire in both cases -- but in the former the presentation suggests that the "Kominko, Maja" source was "reviewed", in the change it suggests that the topic "History of Palestinian journalism" has been "reviewed" - at best (the blist is a mess so it is still ambiguous). I'm not sure what this workflow is supposed to be showing to tell if this made things better or worse? Not blaming you for this, but would much prefer the entire layout got fixed if possible? — xaosflux ^Talk 13:49, 9 April 2024 (UTC)

Neither was reviewed. The thing that "reviewed" pertains to in that case is Template:Did you know nominations/Dahiru Musdapher. * Pppery * _{it has begun...} 14:34, 9 April 2024 (UTC)

So you can see how the location of the bulleted list item makes it very confusing what parent object that statement is meant to be attached to. — xaosflux ^Talk 15:50, 9 April 2024 (UTC)

If the GIGO formatting would not have been harmed by the proposed change, I would like to see it implemented. Here's another example of the sort of error that needs to be fixed a couple of times per day. – Jonesey95 (talk) 22:51, 9 April 2024 (UTC)

Notified: Wikipedia talk:Did you know. * Pppery * _{it has begun...} 03:47, 26 April 2024 (UTC)

 Done @Jonesey95: try it out, ping me if problem requiring revert. Think this entire output could use a rework if someone gets around to it still. — xaosflux ^Talk 09:44, 26 April 2024 (UTC)