User talk:DannyS712/DiscussionCloser

Latest comment: 2 hours ago by Valereee in topic Link not appearing

Suggestion

edit

Thanks, nice script. I would like a couple of things though:

  • Option to remove {{nac}}: for some closes it's inappropriate for the venue and a pain to remove right after the edit.
  • A dropdown of useful characters (e.g. the endash (–) or four tildes). It's a pain having to go into a new tab, type 'endash', then copy and paste the symbol back.

Cheers, J947(c), at 02:06, 30 March 2019 (UTC)Reply

@J947: I agree with the thing about {{nac}}, and have been planning on solving that when I have time. As for the useful characters, I have no idea where to start with that, but I find that I don't need them. I just use "-" on the keyboard, and ~~~~ is also pretty easy to type. --DannyS712 (talk) 02:08, 30 March 2019 (UTC)Reply
Fair enough, I agree that the second point is a minor one that doesn't need to be solved on reflection. Thanks for working on the {{nac}} thingamajig. J947(c), at 02:13, 30 March 2019 (UTC)Reply
@J947: I have completely removed the addition of the nac tag --DannyS712 (talk) 01:39, 13 June 2019 (UTC)Reply
Could it be added back on an optional basis? Emir of Wikipedia (talk) 20:57, 25 August 2020 (UTC)Reply

Suggestion for RM closure

edit

@DannyS712: Instead of removing {{requested move/dated}} can the script rather replace it with {{subst:requested move/end}}? Per WP:RMCLOSE instructions. comrade waddie96 ★ (talk) 12:59, 6 November 2019 (UTC)Reply

@Waddie96: I'll take a look DannyS712 (talk) 17:18, 6 November 2019 (UTC)Reply

Suggestions

edit

Overall it's a really neat and helpful script, but I do have a few suggestions:

  1. Add support for {{Discussion top}} (({{dtop}}).
  2. Increase the z-index to a high number like 1000 to prevent the sidebar going above the popup and background.
  3. Use OOUI for the interface

BrandonXLF (talk) 21:07, 17 December 2019 (UTC)Reply

@DannyS712: It would also be nice if the window was movable and was more of a popup than an overlay, but the current system is fine.BrandonXLF (talk) 06:09, 20 December 2019 (UTC)Reply
@BrandonXLF: thanks for the ping; I'll take a look at writing a v.2 that uses OOUI DannyS712 (talk) 06:10, 20 December 2019 (UTC)Reply

Script is broken

edit

Whatever bottom script it substitutes is a redirect. The correct property to use is {{subst:RM bottom}}. CoronavirusPlagueDoctor (talk about the coronavirus/Contributions about the coronavirus) 22:34, 15 March 2020 (UTC)Reply

@CoronavirusPlagueDoctor: Danny is fixing it. Interstellarity (talk) 22:47, 15 March 2020 (UTC)Reply

Loads Twinkle

edit

Hi @DannyS712, can you remove 'ext.gadget.Twinkle' in the dependencies list on line 298? I believe this was present because Abelmoshcus Esculentus' script originally depended on Morebits which wasn't a gadget by itself at that time. Now I don't see either Morebits or Twinkle being necessary for this to work. BTW even mediawiki.api and mediawiki.Title look unnecessary. – SD0001 (talk) 19:00, 8 April 2021 (UTC)Reply

Reping @DannyS712. The presence of twinkle in dependencies is somewhat disruptive as it means that when a user disables Twinkle from their preferences, Twinkle still loads if the user has this script installed – but it won't be evident to them why Twinkle is still loading. For instance, this is a common point of confusion for new Twinkle developers (who need to disable on-wiki version of twinkle before they can test twinkle locally). – SD0001 (talk) 04:05, 18 November 2021 (UTC)Reply
Done, sorry for not seeing this earlier DannyS712 (talk) 07:19, 20 November 2021 (UTC)Reply

Script Bug

edit

Your script is not working for me as shown here. Lightoil (talk) 20:35, 17 February 2023 (UTC)Reply

 
Screenshot of broken DiscussionCloser
edit

The link to close discussions isn't appearing for me at the top of sections. Valereee (talk) 12:53, 13 June 2024 (UTC)Reply

Same here, unfortunately.
This may or may not be linked to the same MediaWiki updates as reported here: Wikipedia_talk:XFDcloser#XFDCloser_not_showing_up_in_Vector_2010. — kashmīrī TALK 16:49, 22 June 2024 (UTC)Reply
Root cause is mw:Heading HTML changes. Is probably broken on old skins at the moment, and will break on Minerva and Vector 2022 in the coming weeks as they finish the rollout. –Novem Linguae (talk) 14:35, 23 June 2024 (UTC)Reply
Dang, I use this script all the time. Valereee (talk) 15:12, 23 June 2024 (UTC)Reply