Template talk:Main page image/ITN

Latest comment: 3 years ago by Jo-Jo Eumerus in topic Automatic image sizing

This template is sort of broken edit

This template is sort of broken because the link parameter to the image is defaulting to the file page explicitly. This is causing mw:Extension:MultimediaViewer to fail to launch on the image that is embedded with this template. I would suggest only using the link= parameter if there is actually a link parameter, else leaving it out. If we can help with this transition at all, let us know. --MarkTraceur (talk) 20:20, 18 April 2014 (UTC) (on behalf of the Multimedia team at the WMFReply

Compare:

[[File:4 Star.jpg]] ->  

[[File:4 Star.jpg|link=File:4 Star.jpg]] ->  

They look and behave the same but actually generate slightly different markup. MediaViewer uses that difference to check which images to show in a lightbox (which would generally be unwanted for images that serve as links). --Tgr (WMF) (talk) 22:05, 18 April 2014 (UTC)Reply

Mark and Gergő:
Thanks very much for explaining this issue. I've made the requested change. Please confirm that this resolved the problem. —David Levy 20:01, 21 April 2014 (UTC)Reply
Confirmed :) thanks very much. --MarkTraceur (talk) 20:12, 21 April 2014 (UTC)Reply
I don't know if recent edits broke it again, but that one image never shows up in MMV.--Erik Moeller (WMF) (talk) 16:20, 25 November 2014 (UTC)Reply

Protected edit request on 10 December 2014 edit

It looks like this template has broken its usability with MediaViewer, since it no longer emits the correct CSS class that MediaViewer looks for. I've mocked up a fixed version of the template: User:Dmitry_Brant/sandbox/newsimage

DBrant (WMF) (talk) 20:33, 10 December 2014 (UTC)Reply

diff. That's a monstrosity of a template, but I think the logic is correct: it won't use the link thumbnail parameter if the link template parameter is omitted or set to a value which would not do anything useful. The reason MediaViewer does not work is more complex, see phab:T75902. --Tgr (WMF) (talk) 22:17, 10 December 2014 (UTC)Reply

  Partly done: I've converted the template to Module:In the news/image using User:DBrant (WMF)'s template as a base. Hopefully it should be easier to read and have better error checking - and fix the problem at hand. — Mr. Stradivarius ♪ talk ♪ 03:27, 19 December 2014 (UTC)Reply

Broken again? edit

This template seems to be having the same issue as the one mentioned above (the image no longer works with MediaViewer, since it doesn't generate the correct CSS class(es)). Can someone please fix? DBrant (WMF) (talk) 20:19, 19 May 2015 (UTC)Reply

See my comment above. The news section often crops images and MediaViewer does not support that pattern. There is no easy fix for this. --Tgr (WMF) (talk) 09:18, 20 May 2015 (UTC)Reply

Template broken edit

@David Levy: Recent changes to this template seem to have broken {{ITN candidate}}, as shown in Template:ITN_candidate/testcases. Please revert to the working version from prior to July 23rd. Mamyles (talk) 19:06, 23 July 2015 (UTC)Reply

Removing edit request, as reverting may break the main page. Please look into these issues with ITN candidate. I will also post on the thread in Wikipedia_talk:In the news. Mamyles (talk) 19:12, 23 July 2015 (UTC)Reply
Fixed. Apologies for the oversight. —David Levy 21:41, 23 July 2015 (UTC)Reply

center the text edit

can't you just center the text? Bageense (talk) 17:49, 26 January 2019 (UTC)Reply

Automatic image sizing edit

Please replace: 120

With:{{#invoke:Main_page_image|width|{{Remove file prefix|{{{image}}}}}}}

I have tested at Template:In the news/image/sandbox. See results at Template:In the news/image/testcases.

Ping MSGJ, if you have a second. --- C&C (Coffeeandcrumbs) 23:31, 6 August 2020 (UTC)Reply

And while we're at it, since it takes long enough to get these edit requests approved, this template should probably be moved to Template:Main page image/ITN per [1] and for consistency with the other main page image derivatives. ProcrastinatingReader (talk) 11:08, 12 August 2020 (UTC)Reply
Done and done. Jo-Jo Eumerus (talk) 07:58, 28 August 2020 (UTC)Reply