MediaWiki talk:Gadget-NewImageThumb

Latest comment: 1 year ago by Arlolra in topic Prepare for T314318

I like it!

edit

On my user page, I notice a beautiful difference. ~ ToBeFree (talk) 16:18, 29 May 2018 (UTC)Reply

3d effect

edit

Definitely an improvement over the very old fashioned concentric 1px borders! It might be worth considering having all borders the same shade of grey. It seems like interfaces are moving more towards a flat aesthetic at the moment. Don't forget to add a side-by side comparison on MediaWiki:Gadget-NewImageThumb so that it's easier for people to compare the difference! T.Shafee(Evo&Evo)talk 02:15, 26 June 2019 (UTC)Reply

Like User:Evolution and evolvability, I agree that a same-color border would be better. Much cleaner than the current one, and feels less obtrusive—lets the content speak for itself. Der Wohltemperierte Fuchs talk 00:29, 3 March 2021 (UTC)\Reply
@Edokter: Another example to check out would be the styling used over at the WikiJournals. Example to compare:
T.Shafee(Evo&Evo)talk 05:00, 3 March 2021 (UTC)Reply

Remove shadows

edit

I see a shadow on the side of the image, and it would be nice to have an option to remove it. 16AdityaG09 (talk) 09:38, 2 February 2021 (UTC)Reply

Maintainer retired

edit

I've just noticed that the maintainer for this javascript is retired, so will post some changes for an admin over at WT:Gadget based on the comments above. T.Shafee(Evo&Evo)talk 05:06, 3 March 2021 (UTC)Reply

Updated css

edit

Per the recommendation at WT:Gadget, I've darfted an updated version of the formatting below. Please edit this page (the .css subpage) to contain the following:

.tocnumber {
    color: #333;
}
.toc, #toc,
.catlinks,
.mw-gallery-traditional li.gallerybox div.thumb,
div.thumbinner {
    border-width: 0px;
}
div.thumbinner {
    padding: 0;
}
div.thumbinner.mp-thumb {
    box-shadow: none;
}
html .thumbimage {
    border: none;
}
html .thumbcaption {
    line-height: 1.5;
    padding: 0.5em;
}
img.thumbborder {
    border-width: 0px;
}
.tmulti .tsingle {
    margin: 0 !important;
}
  Done Izno (talk) 15:08, 27 March 2021 (UTC)Reply
Hi Izno. Could you revert this please. This change was never approved. It was only recommended to bring the discussion here. Thanks. -- [[User:Edokter]] {{talk}} 08:22, 11 April 2021 (UTC)Reply
@Edokter: Changes don't need to be approved. Please provide a substantive reason for reversion (they don't work, they don't work like expected, they stopped working, yadda yadda). Izno (talk) 13:15, 11 April 2021 (UTC)Reply
@Izno: There was no consensus to begin with. The edit basically removed all styling, and now it only displays a plain box around the TOC and catagory boxes. That is a pretty big impact. I originally wrote it to showcase some new styling. So yes, it definitely doesn't work as expected. -- [[User:Edokter]] {{talk}} 18:12, 11 April 2021 (UTC)Reply
  Done Izno (talk) 18:16, 11 April 2021 (UTC)Reply
Thank you. -- [[User:Edokter]] {{talk}} 18:18, 11 April 2021 (UTC)Reply

Why does this decrease width by two on every render?

edit
 

MediaWiki:Gadget-NewImageThumb.js#L-18 causes things like the image on the right to get smaller when refreshing preview somewhere else on the same page, like when typing in the reply tool Aaron Liu (talk) 04:28, 21 February 2023 (UTC)Reply

Per discussion at VPT, change line 16 and 17 to

mw.hook( 'wikipage.content' ).add( function( $content ) {
    $content.find( '.thumbinner' ).not( '.mp-thumb' ).each( function() {

Aaron Liu (talk) 04:24, 23 February 2023 (UTC)Reply

  Done {{ping|Aaron Liu} can you confirm this is resolved? — xaosflux Talk 14:35, 24 February 2023 (UTC)Reply
It appears to be! Aaron Liu (talk) 20:56, 24 February 2023 (UTC)Reply

Maintain text box width

edit

I really like the new style, maybe the frameless alternative even more, but both look fine. What I'd like to note is that the new width of the text box is a bit smaller than the old one, compressing the caption and causing some undesired linebreaks. It would be nice to maintain the current width of the caption box. Henni147 (talk) 11:13, 21 February 2023 (UTC)Reply

Prepare for T314318

edit

Can someone make this edit in preparation of enabling the changes to media rendering? https://en.wikipedia.org/wiki/Special:ComparePages?page1=MediaWiki%3AGadget-NewImageThumb.css&rev1=1017248689&page2=User%3AArlolra%2Fsandbox%2FGadget-NewImageThumb.css&rev2=1156645340&action=&unhide=

There's some explanation of the reason for this change at mw:Parsoid/Parser_Unification/Media_structure/FAQ

Thank you, Arlolra (talk) 22:31, 23 May 2023 (UTC)Reply

  Done Izno (talk) 16:03, 28 May 2023 (UTC)Reply
Thanks! Arlolra (talk) 23:56, 30 May 2023 (UTC)Reply