Template talk:Allcaps

Add discussion
Active discussions

Template-protected edit request on 5 October 2019Edit

I made a new implamentation with TemplateStyle, which works with class="allcaps", the source code is available at the sandbox page. -- Great Brightstar (talk) 00:31, 5 October 2019 (UTC)

Appears to work fine (/testcases). But can you explain why the new version superior? — Martin (MSGJ · talk) 05:24, 5 October 2019 (UTC)
OK, the new version is made following the same works as {{smallcaps}} and {{smallcaps2}}, which already used TemplateStyles, also make the styles reusable for other templates. --Great Brightstar (talk) 07:57, 5 October 2019 (UTC)
There have been issues with inline templatestyles previously that I've had pop up with my (otherwise fine) implementation. (I don't personally agree that they were significant issues, but I wasn't in the mood to defend the templatestyles changes.) Also, inline templates have a tendency toward being substed, which is a problem for templatestyles templates. --Izno (talk) 15:01, 5 October 2019 (UTC)
Are you saying that the sandbox version would not work if it was substituted? That may be a significant reason not to change this. — Martin (MSGJ · talk) 14:43, 6 October 2019 (UTC)
@MSGJ: Substs work just fine, they just also output the <templatestyles> tag. There may be a way to stop that from occurring, but I don't know it because I haven't looked that hard into how substing works (and certainly, you would lose the styles if that tag were not substed--which might be fine). --Izno (talk) 03:22, 7 October 2019 (UTC)
I did some research; we can take a similar approach to Template:Smallcaps and perhaps in general that's an approach to consider for inline templates (or maybe all templatestyles templates). I will go leave a note at WT:TemplateStyles when I have the opportunity. I do not know if we should support, as at smallcaps, the inline-style version, but I think that is a larger discussion. --Izno (talk) 18:46, 7 October 2019 (UTC)
I don't really have any opinion on this, so you can you implement? — Martin (MSGJ · talk) 19:38, 7 October 2019 (UTC)
@MSGJ and Izno: just wondering who's gonna action this? I don't wanna step on anyone's toes… Sceptre (talk) 01:01, 13 October 2019 (UTC)
  Done No-one has responded to my general question at WT:TemplateStyles#Substed templates r2, which is the discussion on which I was waiting. In the interest of decreasing reliance on inline styles in general, I've implemented this template like smallcaps but without the substed version containing inline styles. Feel free to discuss that point there. --Izno (talk) 01:12, 13 October 2019 (UTC)