User:MarkAHershberger/Weekly reports/2010-W19

Peeking at CodeReview

Since part of the problem with checking in changes that mix whitespace and functional changes seems to be that people want to review the changes using the web interface on CodeReview, I decided to look into what it would take to add a toggle so that the diff could be run without whitespace changes.

Doing this without the PECL module would be easy enough, of course: just add -x-w, but it would be good to have a solution that works for the PECL module without trying to interpret a regular diff and remove whitespace.

So, not being familiar with the underlying code, I dug into the PECL code, found that it was using svn_client_diff3, which would support passing options, but that the option list in the PECL code is set to a series of null strings. This means that the svn library is capable of doing what I want, but it would mean patching the PECL code.

In better news, version 1.0.0 of the PECL svn module was released last week which shows that the code isn't dead. Perhaps they'd be interested in fixing this.

LiquidThreads + NewUserMessage + User::leaveUserMessage()

After a couple of refactorings, I think I've managed to make it possible for the system to leave user's messages on their talk page and have those messages use LiquidThreads functionality if it is available.

I initially started doing this because, as mentioned previously, I wanted a way for the user to be notified of errors as well as successes if they used the “Upload by URL” to copy a file into the wiki.

What I have so far works with my initial testing, but I'd like to make sure I've shaken out all the bugs I can as well as document the hooks and functions I created. I can see this being a useful addition — especially for extension authors who perform asynchronous actions using the JobQueue.

As such, the code still more thorough testing and I need to document the hooks I've created in User::leavUserMessage() as well as the NewUserMessage extension. I also need to use the code in the UploadByUrl code to notify users of a sucessful upload.

Continuum

I briefly chatted with Ryan Lane about setting up Continuum. He said he would provide an instance on the Usability server (where the Selenium Grid is) so that I could configure it as needed. I should be able to get the initial configuration up this week.