Template talk:Cite act

change apparently breaks a lot of articles

This edit, with the inscrutable edit summary: correction with a lot of duplicated code that does what was done before (mediawiki flag), by Editor SamuelRiv appears to have broken a bunch of articles. Category:CS1 errors: URL–wikilink conflict which see. Editor SamuelRiv should either fix the template or fix the articles in the category.

—Trappist the monk (talk) 22:34, 25 April 2024 (UTC)

I'm doing the AWB run in a minute. The title-wikilink url-link conflict is a CS1 thing that I didn't want to squeeze in compatibility for (but maybe I should if CitationBot doesn't have a script for it). The edit that changed it was my complete overhaul of the template, not the after-edit reversion and tweak that I did because of a mw error flag (for which I submitted a phabricator request).

While I'm sure many would like to see CS1 allow simultaneous use of title-link and url to be supported, I believe the requests have been shot down before. The only reason it worked in this template is because this template previously improperly overloaded the title= field (among others) which gives improper metadata. SamuelRiv (talk) 01:20, 26 April 2024 (UTC)

Running AWB after sanitizing in the code, almost all errors seem to have come from an identically-formatted citation to the same section of Terrorism Act 2000. The citation put a wikilink inside the |title= field, and because the original code of {{cite act}} redefined title and df separate from CS1, none of this would get flagged (and title-link wouldn't have done anything in the original code). That's why I am updating the semantics on some of these CS1 wrapper templates, and hopefully getting new or changed styles in the CS1 module itself. SamuelRiv (talk) 18:39, 26 April 2024 (UTC)