User talk:DannyS712/12Hours

Discussion

Moved from Wikipedia:User scripts/Requests

 – DannyS712 (talk) 23:56, 31 January 2019 (UTC)

Would anyone be able to revise User:Bility/convert24hourtime.js? It hasn’t been updated in seven years and it’s quite buggy. The thanks button shows up differently, conflicts with the blocked template in Contributions page, and doesn’t work when looking at diff. -- 1989 (talk) 00:51, 10 January 2019 (UTC)

@1989: I can take a crack at it when I have time, but someone else is welcome to beat me to it. --DannyS712 (talk) 01:08, 10 January 2019 (UTC)

See User:DannyS712/12Hours --DannyS712 (talk) 03:40, 11 January 2019 (UTC)

@1989: forgotten ping --DannyS712 (talk) 03:40, 11 January 2019 (UTC)

@DannyS712: Thanks, however, the block box conflict is still present, and the left side of revision as is not working, only the right. -- 1989 (talk) 03:48, 11 January 2019 (UTC)

@1989: Left side fixed. Block box - I'll try to get to it next week, if I don't just post on my talk please --DannyS712 (talk) 03:54, 11 January 2019 (UTC)

@DannyS712: Thanks again. Would you happen to have this work for the logs as well? -- 1989 (talk) 03:59, 11 January 2019 (UTC)

@1989: I'll do that when I do the block, since it should be the same (block log vs other log) --DannyS712 (talk) 04:02, 11 January 2019 (UTC)

@1989: Done both! Logs and blocks fixed. Eventually I'll get to watchlist.... --DannyS712 (talk) 02:04, 12 January 2019 (UTC)

@DannyS712: The block box issue was fixed, but the script still doesn’t load when the box is present. I also checked the logs, same thing. Also, is there a way to have the option to remove the “unescape('%A0%A0')” thing and have the am/pm fully capitalized? -- 1989 (talk) 02:22, 12 January 2019 (UTC)

@1989: It does for me... 6:45 am, 31 December 2018 User account TripleX.Numb (talk. Maybe purge your common.js or whereever its installed? --DannyS712 (talk) 02:24, 12 January 2019 (UTC)

@1989: Figured it out! You don't have it installed... --DannyS712 (talk) 02:27, 12 January 2019 (UTC)

@DannyS712: I purged it already, and I have it on globally. -- 1989 (talk) 02:28, 12 January 2019 (UTC)

@DannyS712: Nevermind. It’s working now. I made some adjustments (I mentioned it above), which is probably why it didn’t work. -- 1989 (talk) 02:33, 12 January 2019 (UTC)

Will the permalinks be fixed too? -- 1989 (talk) 04:18, 12 January 2019 (UTC)

@1989: What do you mean? --DannyS712 (talk) 04:44, 12 January 2019 (UTC)

@DannyS712: There’s a box that says “This is an old revision of this page” and after it says the time. -- 1989 (talk) 04:48, 12 January 2019 (UTC)

@1989: Seems pretty easy. I'll give it a crack when I have a few hours --DannyS712 (talk) 04:50, 12 January 2019 (UTC)

@DannyS712: What about the custom options? (mentioned above) -- 1989 (talk) 04:51, 12 January 2019 (UTC)

@1989: Same --DannyS712 (talk) 04:52, 12 January 2019 (UTC)

@DannyS712: It doesn’t work on this page. -- 1989 (talk) 04:07, 14 January 2019 (UTC)

@1989: Currently, the special pages it works on are: contributions and logs. I'll try to expand to more soon. --DannyS712 (talk) 05:59, 14 January 2019 (UTC)

@DannyS712: Even here? -- 1989 (talk) 22:49, 14 January 2019 (UTC)

@1989: ? that page has been deleted... --DannyS712 (talk) 23:50, 14 January 2019 (UTC)

@DannyS712: I mean the “A page with this title has previously been moved or deleted.” box. -- 1989 (talk) 23:51, 14 January 2019 (UTC)

@DannyS712: Also the “File History” to here. -- 1989 (talk) 00:56, 15 January 2019 (UTC)

@1989: We'll see. Its a lot to manage, and the more features I add the slower it'll likely going to be --DannyS712 (talk) 00:57, 15 January 2019 (UTC)

@DannyS712: Would I need to remind you later? -- 1989 (talk) 03:59, 18 January 2019 (UTC)

@1989: I'll try to get to it this weekend, but I'm really busy... sorry --DannyS712 (talk) 04:00, 18 January 2019 (UTC)

@1989: Here is my version of the script, purloined from DannyS712. I fixed some bugs and redundancies. Hopefully it is working as expected. If not, please contact me. Guywan (talk) 15:46, 24 January 2019 (UTC)

@Guywan and DannyS712: The 12 is a 0, the File History issue is still there, the user group management page, permalinks and the “A page with this title has previously been moved or deleted.” time hasn’t been changed either. Plus, I can’t change the am/pm to AM/PM. -- 1989 (talk) 15:56, 24 January 2019 (UTC)

@1989: Fixed on user groups --DannyS712 (talk) 16:21, 24 January 2019 (UTC)

@1989: Also fixed user history pages --DannyS712 (talk) 16:26, 24 January 2019 (UTC)

@1989: Also fixed on permalinks --DannyS712 (talk) 16:34, 24 January 2019 (UTC)

Sorry for all of the pings. What do you mean by the 12 being a 0, or the file history issue? --DannyS712 (talk) 16:35, 24 January 2019 (UTC)

@DannyS712: That’s for Guywan’s script, not yours. The others concerns are for both. Plus, the gap is still there that Guywan removed. -- 1989 (talk) 16:37, 24 January 2019 (UTC)

@1989: Do you want to gap eliminated entirely, or just in some situations? I know that for histories and stuff, having the gap makes it align with outher entries --DannyS712 (talk) 16:46, 24 January 2019 (UTC)

@DannyS712: It could be an option to those that want it. I personally find it destracting. -- 1989 (talk) 16:47, 24 January 2019 (UTC)

@1989: And the option would remove it completely? --DannyS712 (talk) 17:18, 24 January 2019 (UTC)

@DannyS712: Yes. -- 1989 (talk) 17:19, 24 January 2019 (UTC)

@DannyS712: The File History and Deletion Notice box hasn’t been changed yet. -- 1989 (talk) 19:04, 24 January 2019 (UTC)

@1989: What do you mean by file history? The history of a file page? Cause it worked on those for me... --DannyS712 (talk) 19:15, 24 January 2019 (UTC)

@DannyS712: Here, and scroll down, You'll see the section, -- 1989 (talk) 19:17, 24 January 2019 (UTC)

@1989: Oh, in the read view, not the "view history" tab. I'll see what I can do --DannyS712 (talk) 19:59, 24 January 2019 (UTC)

@1989: Times in the file history table will be converted now. Note that my solution is imperfect. Anything in the file history table that matches the pattern "nn:nn," where n is a digit, will be converted. Also, I cannot seem to change the time in the “A page with this title has previously been moved or deleted.” box without destroying the links. I might have a solution when I am more familiar with the JS and jQuery APIs. Guywan (talk) 20:19, 24 January 2019 (UTC)

Eureka! Now I know what that regexp was for :-/. Time will be converted in the aforementioned circumstance. Guywan (talk) 20:58, 24 January 2019 (UTC)

Time will be converted on the user rights page. Guywan (talk) 21:11, 24 January 2019 (UTC)

@Guywan: The 0:nn AM issue is still present, and the 12:nn AM is supposed to be PM. It doesn’t work here. -- 1989 (talk) 23:54, 24 January 2019 (UTC)

@DannyS712: The user rights log doesn’t work for Commons, or this page for here. -- 1989 (talk) 23:54, 24 January 2019 (UTC)

@DannyS712: Will it be fixed soon? -- 1989 (talk) 17:52, 25 January 2019 (UTC)

@1989: idk. Sorry, but this isn't a big priority for me. I'll try to get to it this weekend --DannyS712 (talk) 17:54, 25 January 2019 (UTC)

@DannyS712: I understand. Hopefully soon it’ll be complete so I won’t have to bother you anymore. 1989 (talk) 04:05, 30 January 2019 (UTC)

@Enterprisey: Hi. Is there a way you could write a version as well? It could also be part of the gadgets section in the Preferences section as there are users like myself whom don’t settle for the 23 time format. 1989 (talk) 21:24, 31 January 2019 (UTC)

@1989: I'm going to have to work on this soon, but if enterprisey wants to take it over they are welcome to fork my script --DannyS712 (talk) 22:13, 31 January 2019 (UTC)

@1989: Updated. Made significant changes. Might be a few bugs. Let me know. Guywan (talk) 23:02, 31 January 2019 (UTC)

@Guywan: Do you use github? I'd like to collaborate with you, rather than making parallel versions... --DannyS712 (talk) 23:40, 31 January 2019 (UTC)

Hey all, would you mind continuing the discussion on the script's talk page? This section is getting a bit long, and this page keeps popping up on my watchlist without any new requests, just bug reports/fixes for this one. - Evad37 [talk] 23:48, 31 January 2019 (UTC)

@1989 and Guywan: moved per request --DannyS712 (talk) 23:56, 31 January 2019 (UTC)

@DannyS712: Sure. Sounds like a good idea. Guywan (talk) 00:48, 1 February 2019 (UTC)

@Guywan: Do you want to email me, or post a link to your github? --DannyS712 (talk) 02:13, 1 February 2019 (UTC)

@DannyS712: My github account? Here it is. -- Guywan (talk) 11:47, 1 February 2019 (UTC)

@Guywan: The block box doesn’t change. 1989 (talk) 21:06, 1 February 2019 (UTC)

It doesn’t work here. 1989 (talk) 03:04, 2 February 2019 (UTC)

Take a look at this. Tap Create and you’ll see the difference. 1989 (talk) 04:31, 2 February 2019 (UTC)

@1989: Updated. All issues should be resolved. -- Guywan (talk) 13:22, 2 February 2019 (UTC)

User signatures are also converted now. This should work everywhere (except, intentionally, when editing a page's source). What do you think? -- Guywan (talk) 14:42, 2 February 2019 (UTC)

@Guywan: I found it doesn’t work with permalinks. -- 1989 (talk) 17:04, 2 February 2019 (UTC)

Doesn’t work here either, but so far so good. -- 1989 (talk) 17:07, 2 February 2019 (UTC)

Found another one. -- 1989 (talk) 17:09, 2 February 2019 (UTC)

@1989: I was under the impression that permalinks were fixed, but I see that I never got around to them. They are fixed now, anyhow. Both other issues also fixed. -- Guywan (talk) 18:50, 2 February 2019 (UTC)

@Guywan: You mossed the colon in the Edit Filter Log. -- 1989 (talk) 18:52, 2 February 2019 (UTC)

@1989: Fixed. -- Guywan (talk) 19:17, 2 February 2019 (UTC)

@Guywan: I noticed after enabling the script, certain links don't work right. For an example, see Template:Collapse. If you don't notice, purge the page. -- 1989 (talk) 07:17, 4 February 2019 (UTC)

@1989: Do you mean the show/hide buttons? Or is there something else? -- Guywan (talk) 13:05, 4 February 2019 (UTC) I'm sure the problem was the part of the script that tries to convert time in user signatures. I've disabled that feature until such a time as I can amend it. -- Guywan (talk) 13:18, 4 February 2019 (UTC)

There's a button called change visibility that I am unable to click on. @MusikAnimal: Since you have the toolset, could you lend a hand? -- 1989 (talk) 16:39, 4 February 2019 (UTC)

@1989: A lot to read through... :) Could you share links to the diffs? — MusikAnimal ^talk 23:55, 4 February 2019 (UTC)

@MusikAnimal: Here is the version I’m talking about. By the way, check Meta. I made a section regarding MoreMenu as well. -- 1989 (talk) 23:57, 4 February 2019 (UTC)

@1989: Sorry, I'm still not sure what you're requesting. Do you need WP:REVDEL? Which revision? — MusikAnimal ^talk 00:04, 5 February 2019 (UTC)

@MusikAnimal: No. There's an issue where the change visibility button in the Contributions page doesn’t work. They are unable to reproduce the issue because they’re not an admin. I’d figure you could help with that. -- 1989 (talk) 00:08, 5 February 2019 (UTC)

@Amorymeltzer: Would you be able to help? -- 1989 (talk) 15:33, 15 February 2019 (UTC)

@1989, Guywan, and DannyS712: I have not read this whole discussion nor the whole script, but I can tell right away what the issue is. It's with

$(this).children().first().text(rxReplace($(this).children().first().text()));

That's sloppy, and breaks because the revdel link shows up before the date. .mw-changeslist-date is a much more specific selector to run through instead of .mw-contributions-list ~ Amory (u • t • c) 15:49, 15 February 2019 (UTC)

@Guywan: It’s not working on File History anymore. -- 1989 (talk) 17:11, 17 February 2019 (UTC)

@1989: Works for me. Something on you're end has changed (importing a new script? Using a new skin?). If you can figure it out and let me know, I'll see what I can do. -- Guywan ( talk | contribs ) 18:41, 20 February 2019 (UTC)

@Guywan: Scroll down and you’ll see the section. If you don’t notice the change, purge the page. 1989 (talk) 21:11, 20 February 2019 (UTC)

@1989: I see. I was looking at the page on wikipedia, not the one on commons. It looks like commons doesn't want to execute the script. Add this to your commons userspace common.js:

mw.loader.load("https://en.wikipedia.org/w/index.php?title=User:Guywan/Scripts/12HourFormat.js&action=raw&ctype=text/javascript");

That fixed it for me. -- Guywan (talk) 09:23, 23 February 2019 (UTC)

@Guywan: I have the script enabled globally, so that isn’t the issue. -- 1989 (talk) 15:11, 23 February 2019 (UTC)

Go to the aforementioned page, then open your browser's developer tools (you can press F12 in Chrome, or Ctrl+Shift+I in some other browsers). Go to the console. If you see script and file in the console, the script has executed. If the time hasn't been converted, then I haven't the foggiest. It is extremely unlikely that another script is interfering, like a 12to24HourFormat script, perhaps ;-). Good luck. -- Guywan (talk) 18:37, 26 February 2019 (UTC)

@Guywan: I see script, file, and table. The time isn't converted, and I don't see error messages regarding the script. Also, 2600:387:A:3:0:0:0:46 is being converted to 2612:38 AM7:a:3::46 in the logs. Anyway to prevent IPs like this from being affected? -- 1989 (talk) 02:37, 2 March 2019 (UTC)

@1989: Logs fixed. Regarding the file history tables, are the times in the HH:MM, DAY MONTH YEAR format? -- Guywan (talk) 13:33, 4 March 2019 (UTC)

@Guywan: No. (HH:MM, MONTH DAY, YEAR) 1989 (talk) 17:12, 4 March 2019 (UTC)

@1989: That explains it. I hadn't given any thought to date format preferences. It is now fixed. -- Guywan (talk) 19:49, 4 March 2019 (UTC)