User talk:Colonies Chris/Archive/2020/Oct

Latest comment: 3 years ago by Colonies Chris in topic please fix your script (2)

"Feminism in Indonesia" listed at Redirects for discussion

  A discussion is taking place to address the redirect Feminism in Indonesia. The discussion will occur at Wikipedia:Redirects for discussion/Log/2020 September 4#Feminism in Indonesia until a consensus is reached, and anyone, including you, is welcome to contribute to the discussion. Hanif Al Husaini (talk) 07:39, 4 September 2020 (UTC)

Disambiguation link notification for September 7

An automated process has detected that when you recently edited Baldwin Locomotive Works, you added a link pointing to the disambiguation page New York.

(Opt-out instructions.) --DPL bot (talk) 08:32, 7 September 2020 (UTC)

please fix your script (2)

this edit at line 46 broke the cs1|2 template: |website=The|work=New York Times

Trappist the monk (talk) 15:04, 10 September 2020 (UTC)

Still broken; see this diff.

Trappist the monk (talk) 23:46, 11 September 2020 (UTC)

And still not fixed; |work= and |website= are aliases of each other so cannot simultaneously exist in a single cs1|2 template:

If you are not going to fix your script, please be courteous to other editors; review your edits and fix what you broke so that others don't have to cleanup after you.

Trappist the monk (talk) 13:51, 12 September 2020 (UTC)

Thank you for notifying me. You are under no obligation to clean up after me. Simply let know when you spot a problem and I will fix it. In these latest cases, the duplication you've pointed out, although of course undesirable in itself, is not in fact causing a problem. Nonetheless, I will fix my script to avoid this happening in the future. Be happy. Colonies Chris (talk) 14:33, 12 September 2020 (UTC)
the duplication you've pointed out ... is not in fact causing a problem. That isn't true. When equal parameter aliases are used in a cs1|2 template, Module:Citation/CS1 cannot know which of them is the correct alias so it renders the value assigned to whichever alias appears first in the list of aliases. For |work= and |website=, that alias table looks like this:
['Periodical'] = {'journal', 'magazine', 'newspaper', 'periodical', 'website', 'work'}
|website= appears first so it is rendered instead of |work= along with an error message:
{{cite news |title=Title |work=The New York Times |website=nytimes.com}}
"Title". nytimes.com. {{cite news}}: More than one of |work= and |website= specified (help)
In this example, |work=The New York Times is the correct parameter (it isn't always) but cs1|2 cannot know that. We know that writing |publisher=The New York Times is wrong so changing it to one of the periodical parameters is correct but, when there is already a periodical parameter present, one of the (now two) periodical parameters must give way. How that happens is of course, up to you and your script. It is not the place for cs1|2 to make that determination so it renders the first one and emits the redundant parameter error message: More than one of |work= and |website= specified (or similar). Automated tools that leave error messages behind where there were none before is a problem.
Fixing the script is the desired outcome; I found these errors in Category:Pages with citations having redundant parameters; you can too. But, it would be best to fix the script. I am not going to report every error that your script makes; that's almost as much work for me as cleaning up after you and neither is something that I particularly want to do.
Trappist the monk (talk) 15:14, 12 September 2020 (UTC)
I was careful to say that the **latest** issues you've notified are not a problem but I will fix them anyway - I did not cause those problems, my changes simply made visible a pre-existing duplication. I fully accept that some of the issues notified earlier were genuinely a problem, and I have already fixed the cause of them. Thank you for telling me about the category where I can see these issues. Since you are clearly keeping a close eye on that category, you just need to drop me a message if you've spotted something before I do, and I will handle it. Colonies Chris (talk) 15:26, 12 September 2020 (UTC)
Umm, I'm going to dispute that. At 1981 Epsom Derby, your script changed this:
{{cite web |url=https://www.racingpost.com/search/?tab=profiles&page=1&query=&profiles_type=horses_profiles |title=Profiles Search |website=Racing Post |publisher=Racing Post |access-date=April 12, 2020}}
"Profiles Search". Racing Post. Racing Post. Retrieved April 12, 2020.
to this:
{{cite web |url=https://www.racingpost.com/search/?tab=profiles&page=1&query=&profiles_type=horses_profiles |title=Profiles Search |website=Racing Post |work=Racing Post|access-date=April 12, 2020}}
"Profiles Search". Racing Post. Retrieved April 12, 2020. {{cite web}}: More than one of |work= and |website= specified (help)
No error message before, error message after. The redundant |publisher=Racing Post was not a problem, just unnecessary clutter. In this example, |website=Racing Post is semantically the correct parameter so adding |work=Racing Post as a replacement for |publisher=Racing Post is not necessary. Deletion of |publisher=Racing Post would have been the correct action. But, having replaced instead of deleted, your script did cause a problem because the result was a red error message that someone had to fix, me in this case (and, of course, this discussion ...)
Trappist the monk (talk) 16:58, 12 September 2020 (UTC)
As I said, I have fixed my script. Let me know if there are any further problems, I will deal with it. You don't have to fix anything. Colonies Chris (talk) 17:52, 12 September 2020 (UTC)