Template talk:AllMovie title

Review parameter

The review parameter needs to be removed from this external link template. Per WP:ELMAYBE #1, individual reviews should not be external links but instead sources in the article body. Otherwise, the template gives the false impression that it is appropriate to include a review as an EL. Pinging Adabow, Closedmouth. Erik (talk | contrib) ^{(ping me)} 13:18, 18 January 2017 (UTC)

I agree with the need to remove the parameter. Erik if the editors you pinged don't respond why don't you go ahead and file an "edit request" - Thanks for getting this started andd cheers. MarnetteD|Talk 16:56, 18 January 2017 (UTC)

Support removal too. All other EL templates (that I know of) link to the main page on the site they link to, rather than a specfic tab or sub-page/section. Lugnuts ^{Precious bodily fluids} 19:16, 18 January 2017 (UTC)

MarnetteD, Lugnuts, I was going to add a {{editrequested}} template but looking at the code, there is nothing review-specific to remove. I suppose it is a question of if we want to remove the tab feature entirely. There's less a case against the other kinds of tabs, so perhaps the simplest answer here is to update the documentation to exclude "review" from the list of choices for parameters. Thoughts? Erik (talk | contrib) ^{(ping me)} 14:14, 19 January 2017 (UTC)

That sounds good Erik. The point that I was making is that, since the template is fully protected, we need to get an admin involved to perform the edit and an edit request might be the quickest way to get that to happen. Any other ideas that you have of how to get this done is fine by me. Cheers. MarnetteD|Talk 16:23, 19 January 2017 (UTC)

This discussion was recently brought to my attention. @Erik, Lugnuts, and MarnetteD: did anything ever come of this? NinjaRobotPirate (talk) 06:53, 3 June 2017 (UTC)

No, nothing did, but it still goes against policy for a review to be added to the EL section. It should be removed across the board. Erik (talk | contrib) ^{(ping me)} 12:53, 3 June 2017 (UTC)

9 July 2016: same question, opposite answer. --Mauro Lanari (talk) 16:36, 3 June 2017 (UTC)

Please note: a) that wasn't really an opposite answer and b) even if it was WP:CONSENSUSCANCHANGE and this conversation would indicate that it has. It should be removed. MarnetteD|Talk 17:14, 3 June 2017 (UTC)

Of course the consensus can change, but for now it has not yet changed and instead I was even banned 24 hours for believing in that answer. My compliments. --Mauro Lanari (talk) 17:46, 3 June 2017 (UTC)

I thought it was going to be removed based on the EL policy but the discussion was just forgotten about. Time to remove it now. Lugnuts ^{Fire Walk with Me} 07:33, 5 June 2017 (UTC)

There seems to be consensus here to remove support for directly linking to reviews via this template. This seems to be done through the "tab=review" parameter. Please remove this functionality. Thanks. NinjaRobotPirate (talk) 02:10, 12 June 2017 (UTC)

Nope, there's still no consensus at all. Since it's very common to find an "Allmovie rating" without any reviewer, then who does that rating? How can it be considered an "individual review" instead of an "aggregate rating"? --Mauro Lanari (talk) 02:28, 12 June 2017 (UTC)

I came here to service the edit request, but find myself having an opinion for once... For context, |tab= is used about 80 times out of the 20k uses (0.4%), a substantial number of which contain "review" as the value. It might indeed be valuable to remove the tab-specific functionality, as a) citations should use the most-specific link anyway, b) non-citation uses of this template are likely in the vast majority, probably used as a generic external link template. I would support removal of the functionality entirely. --Izno (talk) 02:42, 12 June 2017 (UTC)

They're almost all mine after the answer I received from FleetCommand. Since he retired (sic), I was left alone and I prefer to keep the problem for me and not to put myself anymore in this kind of discussion.

Ps: once the review parameter has been removed, nothing has yet been said and decided about the "Allmovie rating", precisely since it's not related to any single, personal reviewer. --Mauro Lanari (talk) 04:23, 13 June 2017 (UTC)

• Support removing the functionality and excluding it from documentation per WP:ELMAYBE #1 clearly indicating that review-based links should not be external links but rather incorporated in the article body where applicable. Erik (talk | contrib) ^{(ping me)} 15:59, 13 June 2017 (UTC)

It should be easy enough to add a conditional statement to not allow "review" as a valid value for |tab=. I added a tracking category Category:AllMovie titles with a tab value of review, but it may take a day or so for it to be populated as pages are updated, and I'm going through and removing all the review links I can find in external link sections. Once the existing uses are cleared up, I can update the template per the consensus here so that tab=review will no longer function. --Ahecht (TALK
PAGE) 20:56, 13 June 2017 (UTC)

@Mauro Lanari:, please stop adding in review scores to the external link sections, even if they are "meta reviews" ([1][2][3][4]). There is clear consensus here and at WP:ELMAYBE that reviews should be included in the prose, not in the external link section. --Ahecht (TALK
PAGE) 23:14, 13 June 2017 (UTC)

True for the reviews. False for the ratings. --Mauro Lanari (talk) 23:17, 13 June 2017 (UTC)

 Done I updated the template so it no longer passes through a tab value of "review". --Ahecht (TALK
PAGE) 17:04, 19 June 2017 (UTC)

Add Wikidata property support

Please sync with sandbox to pull in support for Wikidata property: AllMovie title ID (P1562). Thank you. 50.53.1.33 (talk) 21:08, 9 February 2017 (UTC)

Done Please update the documentation. Cabayi (talk) 22:20, 9 February 2017 (UTC)

Author

Could the parameters |author= and |first= and |last=, similar to how {{AllMusic}} does it, please be added to this template? -- Michael Bednarek (talk) 13:24, 26 December 2017 (UTC)

Template is throwing spurious errors

Someone needs to fix this.

• DIFF
• DIFF

wbm1058 (talk) 19:17, 16 August 2023 (UTC)

Same problem at Fly Me#External links: {{AllMovie title|m1525322}} successfully resolves to https://www.allmovie.com/movie/vm1525322, and works correctly in the article, but it nonetheless tells readers "Invalid ID." — Fourthords | =Λ= | 02:45, 22 October 2023 (UTC)

{{AllMovie title|m1525322|Fly Me {{noitalic|(1972)}}}} works: Fly Me (1972) at AllMovie. Same for Victoria (2016) at AllMovie. Maybe the documentation is unhelpful. -- Michael Bednarek (talk) 04:29, 22 October 2023 (UTC)

Testing that code at Fly Me also resolves to the correct AllMovie page, but kicks out the same error adjacent to the link: "Invalid ID." — Fourthords | =Λ= | 05:07, 22 October 2023 (UTC)

Beats me. Must be some bad influence of Wikidata. You're right, needs to be fixed. -- Michael Bednarek (talk) 05:48, 22 October 2023 (UTC)

Curiously, it works fine on the template documentation page, where I don't see the "Invalid ID." – wbm1058 (talk) 03:18, 23 October 2023 (UTC)

It's not a bad influence from Wikidata because Fly Me doesn't have an entry for AllMovie. I think it's an error in the way {{ns0}} is used. -- Michael Bednarek (talk) 06:48, 23 October 2023 (UTC)

Oh, right, that error check is only done in mainspace, so that's why we only see errors in mainspace!

It's not Wikidata that's behind the "problem", it's the AllMovie database itself.

The URL is https://www.allmovie.com/movie/vm1525322 – the format of the URL is the letters "vm" followed by a number.

Here's another example, one that still "works" –Citizen Kane#External links – https://www.allmovie.com/movie/citizen-kane-vm428932

See the inconsistency? https://www.allmovie.com/movie/vm428932 still works without the "citizen-kane-"

Actually, the template on that article is coded as {{AllMovie title|9737|Citizen Kane}}

The {{AllMovie title}} template adds a "v" before the number, and links to https://www.allmovie.com/movie/v9737 – which works too.

Seems that AllMovie has changed the URL format for their movie links. "v9737" now redirects to "vm428932".

Yes, indeed! I can break Citizen Kane too by upgrading to use their new code! The link still works, bypassing the AllMovie redirect, but now the template reports the "Invalid ID." error. – wbm1058 (talk) 13:46, 23 October 2023 (UTC)

I think we may need to change the pattern |target=v%D ("v followed by not a number") to "v, optional m, followed by a number". I have been playing around in the sandbox and haven't quite got it yet. – Jonesey95 (talk) 16:28, 25 October 2023 (UTC)

I believe that I have fixed it, allowing both all-numeric and m+numeric ids. Please report any problems here. – Jonesey95 (talk) 16:42, 25 October 2023 (UTC)

Ayyyyy! Thanks for fixing it! — Fourthords | =Λ= | 11:56, 26 October 2023 (UTC)