Talk:Cohen–Sutherland algorithm

Latest comment: 1 year ago by Curiousdolphin in topic Implementation

[Untitled] edit

what is outcode is the point is on the line x=xmin or x=xmax or y=ymin or y=ymaz ? please help me

It has to be INSIDE when it's on the boundary, otherwise the loop will never terminate (unless both points are initially INSIDE.) 2620:79:0:165:1A03:73FF:FE20:3C3B (talk) 01:30, 13 November 2012 (UTC)Reply

Implementation edit

if (!(outcode0 | outcode1)) { // Bitwise OR is 0. Trivially accept and get out of loop

Wouldn't logical OR be faster and more intuitive here? Also, shouldn't the whole algorithm be rewritten using Allman indentation style? And the last point, shouldn't we use use more structured approach? while (true) and breaks may be not friendly for beginners. My opinion. FaTony (talk)

I think the code is missing the definition of the TOP constant: const int TOP = 8; // 1000 Curiousdolphin (talk) 13:20, 28 December 2022 (UTC)Reply

License? edit

Where was the C/C++ example source code taken from? Is there a license to go along with it? Stéphane Charette (talk) 08:54, 22 February 2017 (UTC)Reply