User talk:Citation bot/Archive 9

Active discussions

journal = www.foobar.com → journal = Www.foobar.com

Status
{{fixed}}
Reported by
Headbomb {t · c · p · b} 14:00, 9 August 2018 (UTC)
Type of bug
Garbage in/Garbage out
What happens
|journal=www.foobar.com|journal=Www.foobar.com
What should happen
no change
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Nevskia&diff=854179323&oldid=854171535
We can't proceed until
Agreement on the best solution


The bot is not a human being, it cannot always deal with rubbish. Technically, DNS is not case sensitive, so it is not a bug. I guess we can add a check for "starts with www". AManWithNoPlan (talk) 14:08, 9 August 2018 (UTC) $data='rubbish'; $data = $bot->process($data); // $data now contains 'new rubbish'

Well, you can add an exception for |journal=www\.. Headbomb {t · c · p · b} 14:16, 9 August 2018 (UTC)
https://github.com/ms609/citation-bot/pull/524. AManWithNoPlan (talk) 21:10, 9 August 2018 (UTC)

convert work to journal in cite journal, convert work to magazine in cite magazine

I think the first one is already done (|work=|journal=) in [1], but something similar should also be done in {{cite magazine}} (|work=|magazine=). Headbomb {t · c · p · b} 16:21, 12 August 2018 (UTC)

https://github.com/ms609/citation-bot/pull/550 AManWithNoPlan (talk) 01:27, 13 August 2018 (UTC)

{{fixed}}

Adding citeseerx url where citeseerx parameter exists

In edit one the bot added citeseerx. In edit two it added the url to the citeseerx paper. This seems like unnecissary, and it seems weird that a second run diectly after the previous run results in "more", and not everything is added during the first run.

https://en.wikipedia.org/w/index.php?title=Stephen_Hawking&diff=prev&oldid=854866425

--(tJosve05a (c) 09:44, 14 August 2018 (UTC)

https://github.com/ms609/citation-bot/pull/543 AManWithNoPlan (talk) 13:38, 14 August 2018 (UTC)
Still does it [2], and also adds handle urls when hdl is already set. Headbomb {t · c · p · b} 05:05, 15 August 2018 (UTC)
Yup. Until that pulls is pulled, it will still do that. :-( AManWithNoPlan (talk) 14:17, 15 August 2018 (UTC)
New pull to actually fix it. https://github.com/ms609/citation-bot/pull/572 AManWithNoPlan (talk) 03:37, 16 August 2018 (UTC)

{{fixed}}

GIGO? PMID=0

Status
{{fixed}}
Reported by
Headbomb {t · c · p · b} 18:14, 14 August 2018 (UTC)
Type of bug
Inconvenience
What happens
bot adds nonsensical pmid=0
What should happen
add nothing when the identifier doesn't make sense
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Keith_Reemtsma&diff=854920633&oldid=854920608
We can't proceed until
ConsensusMaintainer


The database does return zero for the PMID. https://eutils.ncbi.nlm.nih.gov/entrez/eutils/esummary.fcgi?tool=DOIbot&email=martins@gmail.com&db=pmc&id=2676591 AManWithNoPlan (talk) 19:22, 14 August 2018 (UTC)

Pull submitted. https://github.com/ms609/citation-bot/pull/559 AManWithNoPlan (talk) 19:28, 14 August 2018 (UTC)
Which did not work. New one. https://github.com/ms609/citation-bot/pull/566 AManWithNoPlan (talk) 14:16, 15 August 2018 (UTC)

N Y --> N y

Status
{{fixed}}
Reported by
Headbomb {t · c · p · b} 01:02, 15 August 2018 (UTC)
What happens
changes |journal=... N Y... to |journal=... N y...
What should happen
Keep N Y as N Y
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Sj%C3%B6gren_syndrome&diff=prev&oldid=854968717
We can't proceed until
Agreement on the best solution


of --> Of

Status
{{fixed}}
Reported by
Headbomb {t · c · p · b} 05:13, 15 August 2018 (UTC)
What happens
changes |journal=... of... to |journal=... Of ...
What should happen
leave it alone
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Albert_Marden&diff=prev&oldid=854992097
We can't proceed until
Agreement on the best solution


Possibly caused by the dot before 'Of'. It might be easier to add an exception for

  • Ann of Math
  • Ann of Math (2)
  • Ann of Sci
  • Ann. of Math.
  • Ann. of Math. (2)
  • Ann. of Sci.

which I believe are the only ones affected by this.Headbomb {t · c · p · b} 05:13, 15 August 2018 (UTC)

Special case for "Ann. of " https://github.com/ms609/citation-bot/pull/565 AManWithNoPlan (talk) 14:30, 15 August 2018 (UTC)

More caps

  • För/för [3]
  • Für/für [guessing this might be problematic too]

Headbomb {t · c · p · b} 06:06, 15 August 2018 (UTC)

Actually we already had the fur version. https://github.com/ms609/citation-bot/pull/565 AManWithNoPlan (talk) 14:30, 15 August 2018 (UTC)

{{fixed}}

Don't remove wikilinks from |title=, use |title-link= instead

Instead of removing wikilinks form |title=, the bot should add the link as |title-link=. https://en.wikipedia.org/w/index.php?title=Ignore_all_rules&diff=prev&oldid=855068220 was a bad edit. User:Josve05a 18:28, 15 August 2018 (UTC)

I have added some code that adds support for title-link should be deployed at some point. https://github.com/ms609/citation-bot/pull/569 AManWithNoPlan (talk) 22:31, 15 August 2018 (UTC)

{{fixed}}

Invalid ISBN

The bot added an invalid ISBN in this edit. 978160558012X is not valid. Might be GiGo. (tJosve05a (c) 06:42, 16 August 2018 (UTC)

GIGO it is. That’s the crossref ISBN. https://api.crossref.org/v1/works/http://dx.doi.org/10.1145/1358628.1358871 Someone changed the ISBN 10 to a 13 and forgot that the check digit often changes. It certainly is never X! Since ISBN is a parity check and not an ECC type check we have no way of knowing what the error is. Also a few books have been assigned invalid ISBN by publishers over the years. That’s minor compared to the using the same ISBN for multiple books—which is one reason there is no {{cite ISBN}}. AManWithNoPlan (talk) 13:41, 16 August 2018 (UTC)

{{notabug}}

Invalid DOI

The bot added | doi = 10.4244/ | doi-broken-date = 2018-08-16 in this edit. Seem wrong. Shouldn't we validate doi's before adding to avoid garbage? (tJosve05a (c) 07:41, 16 August 2018 (UTC)

Personally, I prefer the garbage addition in cases like this. It make humans look for the real, non-garbage doi. Headbomb {t · c · p · b} 12:11, 16 August 2018 (UTC)
I should note several things. That is a standards compliant DOI-a suffix of zero length is allowed. That is the DOI according to pubmed. It is clearly rubbish though. There has been a long discussion on this in the past and generally people seem to like dead DOIs since often you can google the string and find them. Although perhaps an empty suffix is pretty useless. AManWithNoPlan (talk) 13:16, 16 August 2018 (UTC)
Once this is committed, the Bot will require that DOIs have at least one character in the suffix and one character in the prefix. https://github.com/ms609/citation-bot/pull/580 AManWithNoPlan (talk) 13:55, 16 August 2018 (UTC)

{{fixed}}

Bibcodes are not expanded

Status
{{fixed}}
Reported by
Lithopsian (talk) 20:19, 5 March 2018 (UTC)
Type of bug
Inconvenience
What happens
Templates containing a bibcode are not expanded
Replication instructions
Run bot against 1 Camelopardalis which contains several unexpanded citations
We can't proceed until
A specific edit to the bot's code is requested below.
Requested action from maintainer
Figure out why it is failing on tool servers


{{cite journal|bibcode=1985A&AS...60...99W}} for those not wanting to look. AManWithNoPlan (talk) 00:13, 6 March 2018 (UTC)

My data handling improvements have already fixed this bug on GitHub development branch AManWithNoPlan (talk) 03:52, 6 March 2018 (UTC)
Is not filling in the bibcode when, for example, expanding from doi also fixed by this?
Tested with 2018/07/23 release, appears not fixed. Lithopsian (talk) 14:31, 24 July 2018 (UTC)
This is not fixed on Wikipedia servers, but it seems to work on the Travis servers and at home. Strange. AManWithNoPlan (talk) 02:39, 29 July 2018 (UTC)
Looks like the problem is that we've exhausted our 5000 queries for the day. I'll request a second key for testing, which may go some way to help. Martin (Smith609 – Talk) 05:57, 30 July 2018 (UTC)
@Smith609: you can mention to the NASA folk that User:Bibcode Bot has been whitelisted for infinite (and I believe unthrottled) queries. Headbomb {t · c · p · b} 13:12, 30 July 2018 (UTC)
  • We've been granted extra requests, and I plan to refactor the code in the future so it makes better use of them. Marking as {{fixed}}. Martin (Smith609 – Talk) 09:42, 3 August 2018 (UTC)
I just tried it on User:Headbomb/sandbox3... doesn't seem to work. Headbomb {t · c · p · b} 12:03, 3 August 2018 (UTC)
Does not work for me either. I wonder if he forgot key. AManWithNoPlan (talk) 13:05, 3 August 2018 (UTC)
Expand citation: 
- Checking AdsAbs database
x PHP_ADSABSAPIKEY environment variable not set. Cannot query AdsAbs. [..> yadsabs]: no record retrieved. [..> rossref]
- Checking CrossRef database for doi.  [..> indpmid]
- Searching PubMed...  nothing found.

Possibly related, there seems to be something weird with that log beyond the key not being set. ..> yadsabs]: no record retrieved. [..> Crossref] (stray y? Missing C?). Headbomb {t · c · p · b} 19:49, 14 August 2018 (UTC)

that’s debug information compressed to seven letters or less. AManWithNoPlan (talk) 02:32, 17 August 2018 (UTC)
It's working! Thank you very much to whoever made this happen! Headbomb {t · c · p · b} 14:40, 17 August 2018 (UTC)

It seems to be down right now

500 Internal Server Error AManWithNoPlan (talk) 04:43, 17 August 2018 (UTC)

{{fixed}} AManWithNoPlan (talk) 13:14, 17 August 2018 (UTC)

Whitelist all whitelisted parameters

See Module:Citation/CS1/Whitelist for a list. Can't we invoke this list somehow instead of a manually maintaining one on GitHub? (tJosve05a (c) 08:11, 27 July 2018 (UTC)

we are very aware of that page. We could https a copy and then use http://php.net/manual/en/lua.call.php to run it or we could parse it with php if we are gutsy. another idea is to have a process update the list automatically and make a git pull. AManWithNoPlan (talk) 13:21, 27 July 2018 (UTC)
is it possible to directly run wiki lua files on the tool server without https getting them? AManWithNoPlan (talk) 13:25, 27 July 2018 (UTC)
Not sure if the question was adressed to me, because I have no idea. (tJosve05a (c) 06:26, 16 August 2018 (UTC)

https://github.com/ms609/citation-bot/pull/599 AManWithNoPlan (talk) 17:55, 19 August 2018 (UTC)

  Fixed AManWithNoPlan (talk) 00:02, 21 August 2018 (UTC)

Bot does not always do what it says it is going to do

Status
  Fixed
Reported by
Martin (Smith609 – Talk) 14:57, 17 August 2018 (UTC)
Type of bug
Improvement
What happens
In this citation

Lucas (2015). "Thinopus and a Critical Review of Devonian Tetrapod Footprints". Ichnos. 22 (3–4): 136–154. doi:10.1080/10420940.2015.1063491.

the bot reports "~ Recognized DOI in URL; dropping URL", but doesn't drop the URL.

What should happen
It should probably drop the URL, or perhaps not say that it's about to.
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Devonian&diff=prev&oldid=855333297


https://github.com/ms609/citation-bot/pull/589 AManWithNoPlan (talk) 15:41, 17 August 2018 (UTC)

Category API is crap

Status
  Fixed
Reported by
Headbomb {t · c · p · b} 20:06, 17 August 2018 (UTC)
Type of bug
Improvement
What happens
Running the bot on a category produced a huge mess of text on a webpage. Only one page is expanded. Need the slow option.
Relevant diffs/links
https://tools.wmflabs.org/citations/category.php?cat=AfC_submissions_by_date/01_August_2017


It always has been, the weight of tradition is against you. 😬😄😂😆😜😏 AManWithNoPlan (talk) 20:52, 17 August 2018 (UTC)

The problem is that the tool outputs text, not HTML. HTML ignores linefeeds. It really is designed to be run on the command line. AManWithNoPlan (talk) 20:55, 17 August 2018 (UTC)
It also seems to not edit the majority of articles it could edit. I'll investigate further, but it seems running the bot on individual articles in a category yield more edits. BTW, the new API for the single page run is beautiful. Headbomb {t · c · p · b} 20:56, 17 August 2018 (UTC)
The category code runs in FAST mode, that nice little check box that defaults to SLOW is not an option. AManWithNoPlan (talk) 21:06, 17 August 2018 (UTC)
That's certainly a bummer. Maybe it should be. Headbomb {t · c · p · b} 21:08, 17 August 2018 (UTC)
I had them change the "Expand citations" link off to the left size to that mode a while back. At least a "&slow=1" option should probably be added. AManWithNoPlan (talk) 21:09, 17 August 2018 (UTC)
I shall take the fact that your complaint is "The formatting of the logfile offends my sensibilities" as a compliment to the current state of the bot. AManWithNoPlan (talk) 21:11, 17 August 2018 (UTC)
https://github.com/ms609/citation-bot/pull/596 AManWithNoPlan (talk) 22:06, 17 August 2018 (UTC)
https://github.com/ms609/citation-bot/pull/598 AManWithNoPlan (talk) 22:12, 17 August 2018 (UTC)
Turning on slow mode did more https://en.wikipedia.org/w/index.php?title=Draft%3ADr._Erick_Jones&type=revision&diff=855458969&oldid=855458884 AManWithNoPlan (talk) 13:03, 18 August 2018 (UTC)
What's the syntax? https://tools.wmflabs.org/citations/category.php?cat=GATEGORY&slow=1 ? Headbomb {t · c · p · b} 13:35, 18 August 2018 (UTC)
yes AManWithNoPlan (talk) 19:39, 18 August 2018 (UTC)
Just following this discussion, when I run it like this it only analyzes 1 page in the category. Retrying it makes it run on one more article etc etc. Redalert2fan (talk) 19:47, 18 August 2018 (UTC)
What full URL are you using? AManWithNoPlan (talk) 20:13, 18 August 2018 (UTC)
For example: https://tools.wmflabs.org/citations/category.php?cat=Electric_multiple_units_of_Japan&slow=1 Redalert2fan (talk) 20:15, 18 August 2018 (UTC)
interesting. It only works on one page and stops. AManWithNoPlan (talk) 21:33, 18 August 2018 (UTC)
The same happens without &slow=1 , it seems categories are broken... Redalert2fan (talk) 08:53, 19 August 2018 (UTC)
Broken for a long time actually. AManWithNoPlan (talk) 18:08, 19 August 2018 (UTC)
https://github.com/ms609/citation-bot/pull/612 AManWithNoPlan (talk) 18:59, 19 August 2018 (UTC)

Multiple pages now fixed. AManWithNoPlan (talk) 02:04, 20 August 2018 (UTC)

I'm not sure that I ever envisaged this page being used by actual humans! Glad that it's coming in useful. As a treat, it is now in glorious technicolour (-: Martin (Smith609 – Talk) 14:21, 21 August 2018 (UTC)

category output is ugly and generally useless

Category/Slow modes now fixed and working like a charm, but API is still outputting pretty unreadable crap. Headbomb {t · c · p · b} 15:57, 20 August 2018 (UTC)
  Fixed AManWithNoPlan (talk) 00:07, 21 August 2018 (UTC)

Failed to capitalize when there's an & ?

Status
  Fixed
Reported by
Headbomb {t · c · p · b} 00:51, 18 August 2018 (UTC)
Type of bug
Improvement
What happens
Doesn't capitalize
What should happen
Should capitalize
Relevant diffs/links
[4] diff of what it should do, but doesn't


This is possibly because there's nothing else but capitalization going on. Headbomb {t · c · p · b} 00:56, 18 August 2018 (UTC)

Are you sure it does not. It does for me. AManWithNoPlan (talk) 00:57, 18 August 2018 (UTC)

Do not add / remove class

Status
  Fixed
Reported by
Headbomb {t · c · p · b} 01:04, 18 August 2018 (UTC)
Type of bug
Improvement
What happens
The bot adds |class= to cite journal. |class= is a parameter that's only useful in {{cite arxiv}} (and possibly {{citation}}, although that's bad practice).
What should happen
The bot should not add |class= in {{cite journal}} or others, and should remove it when encountered. It should only add it to {{cite arxiv}}, and only keep it in {{cite arxiv}} and {{citation}}. But if there's a |doi= in {{citation}}, remove |class=.
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Precision_tests_of_QED&type=revision&diff=855399984&oldid=854172669


https://github.com/ms609/citation-bot/pull/601 AManWithNoPlan (talk) 17:58, 19 August 2018 (UTC)

For User:Smith609 asking for consensus, see this thread. Headbomb {t · c · p · b} 00:20, 20 August 2018 (UTC)

Remove location in cite journal

Status
  Fixed
Reported by
Headbomb {t · c · p · b} 13:37, 18 August 2018 (UTC)
Type of bug
Improvement
What happens
Bot removes |publisher=, but not |location=
What should happen
bot should remove |location= as well
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Draft:James_Joachim_Hurtak&curid=41551844&diff=855462164&oldid=849448384


https://github.com/ms609/citation-bot/pull/600 AManWithNoPlan (talk) 18:34, 18 August 2018 (UTC)

Remove stray commas at the end of title

Status
  Fixed
Reported by
Headbomb {t · c · p · b} 01:16, 18 August 2018 (UTC)
Type of bug
Improvement
What happens
Doesn't remove stray commas in |title=
What should happen
Remove stray commas in |title=
Relevant diffs/links
[5] diff of what should happen, but doesn't


https://github.com/ms609/citation-bot/pull/611 AManWithNoPlan (talk) 18:20, 19 August 2018 (UTC)

Capitalization is hard

Los Angeles should not be changed to los Angeles in |journal= as in https://en.wikipedia.org/w/index.php?title=Smilodon&diff=prev&oldid=855615980 (tJosve05a (c) 16:26, 19 August 2018 (UTC)

https://github.com/ms609/citation-bot/pull/610 AManWithNoPlan (talk) 18:06, 19 August 2018 (UTC)

  Fixed AManWithNoPlan (talk) 23:38, 20 August 2018 (UTC)

Use |title-link= for linked italicized titles as well

https://en.wikipedia.org/w/index.php?title=Tarrasch_Defense&diff=855512383&oldid=836004652 here the wikilink was just removed. (tJosve05a (c) 21:16, 18 August 2018 (UTC)

should remove italics too. AManWithNoPlan (talk) 21:22, 18 August 2018 (UTC)
Italic markup should be removed from 'book' citations (|work= or aliases not set) but a cs1|2 template with a wikilinked |title= and without |url= is perfectly legitimate; there is an article Modern Chess Openings so:
{{Citation |last=de Firmian |first=Nick |authorlink=Nick de Firmian |year=2008 |title=[[Modern Chess Openings]] |edition=15th |publisher=McKay |isbn=978-0-8129-3682-7}}
de Firmian, Nick (2008), Modern Chess Openings (15th ed.), McKay, ISBN 978-0-8129-3682-7
is a correctly formed citation. This form is supported by the cs1|2 documentation at Template:Citation#Title which read.
Do not misunderstand my point here as a contradiction of what I wrote elsewhere. When the whole title is wikilinked, that is acceptable. But, when the title looks like this one from the other discussion, wikilinking is inappropriate:
|title=A definitive abelisaurid theropod dinosaur from the early Late Cretaceous of [[Patagonia]]
Trappist the monk (talk) 16:49, 19 August 2018 (UTC)
  Fixed https://github.com/ms609/citation-bot/pull/604 AManWithNoPlan (talk) 18:03, 19 August 2018 (UTC)

Do not remove partial wikilinks in titles

In https://en.wikipedia.org/w/index.php?title=Donald_Trump&diff=prev&oldid=855512893 the bot changed

|title=[[Trump Revealed]]: The Definitive Biography of the 45th President

to

|title=Trump Revealed: The Definitive Biography of the 45th President

I don't belive this should be done. (tJosve05a (c) 21:22, 18 August 2018 (UTC)

These links are almost always wrong. They are things like title=[[Trump]] [[Revealed]]: The Definitive Biography of the 45th [[President]]. AManWithNoPlan (talk) 18:01, 19 August 2018 (UTC)
Yes, but in cases of human error/garbage input, a bot should not be the arbitor of what is and what isn't correct. In this case it is correct, yet the bot will continue to bot war unless specifically told not to edit the page. (tJosve05a (c) 19:15, 19 August 2018 (UTC)
Or you can use |title-link=Trump Revealed. Headbomb {t · c · p · b} 00:25, 20 August 2018 (UTC)
That would link the entire content of the |title=. In this case that is perhaps an acceptable solution, but not in all. (tJosve05a (c) 01:06, 20 August 2018 (UTC)
good idea. If more than one link remove. Otherwise expand to whole text. That will encourage people to fix bad ones AManWithNoPlan (talk) 02:06, 20 August 2018 (UTC)

https://github.com/ms609/citation-bot/pull/620 AManWithNoPlan (talk) 17:31, 20 August 2018 (UTC)   Fixed AManWithNoPlan (talk) 23:38, 20 August 2018 (UTC)

Caps: da --> Da

Status
  Fixed
Reported by
Headbomb {t · c · p · b} 00:50, 19 August 2018 (UTC)
What happens
Capitalizes 'da'
What should happen
should not
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Diet-induced_obesity_model&diff=prev&oldid=855531794


Bot added invalid ISBN

Status
  Won't fix
Reported by
Jonesey95 (talk) 19:12, 19 August 2018 (UTC)
Type of bug
Inconvenience: Humans must occasionally make immediate edits to clean up after the bot
What happens
For doi:10.1145/1358628.1358871, the bot added the invalid ISBN 978160558012X.
What should happen
The actual ISBN as listed on the DOI page is 978-1-60558-012-8. Perhaps this is GIGO from a different source.
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Wikipedia_administrators&type=revision&diff=855141849&oldid=854788406


  Not a bug the ISBN in the metadata is 978160558012X sadly. https://api.crossref.org/v1/works/http://dx.doi.org/10.1145/1358628.1358871 AManWithNoPlan (talk) 19:19, 19 August 2018 (UTC)

Just because it is invalid does not mean that it is wrong, such as the evil ISBN 0-7315-0342-1 which are tracked in https://en.wikipedia.org/wiki/Category:Pages_with_listed_invalid_ISBNs AManWithNoPlan (talk) 20:13, 19 August 2018 (UTC)

Clean up PMC

Status
new bug
Reported by
(tJosve05a (c) 22:37, 19 August 2018 (UTC)
Type of bug
Improvement
What should happen
The bot should replace |PMC=PMC3814821 with |PMC=3814821. See Category:CS1 maint: PMC format.
We can't proceed until
Agreement on the best solution


https://github.com/ms609/citation-bot/pull/616 AManWithNoPlan (talk) 14:26, 20 August 2018 (UTC)

  Fixed AManWithNoPlan (talk) 00:01, 21 August 2018 (UTC)

|editorn-first= 

|editor-lastn= and |editor-firstn= is the recognized paramenter, while |editorn-first= (and last) is an alias - not the other way around. The bot should not change |editorn-first= to |editor-firstn= as in https://en.wikipedia.org/w/index.php?title=Rhagonycha_greeni&diff=prev&oldid=855515605 (tJosve05a (c) 21:49, 18 August 2018 (UTC)

There is no reason to change these parameters from one legitimate form to another legitimate for except to unify the form within the template. This applies to all multi word enumerated parameters: |author-mask6=, |interviewer5-link=, etc
Trappist the monk (talk) 16:58, 19 August 2018 (UTC)
this is because the citation templates have sooo many parameter choices. This pull now will add all of them and will also add a check to make sure that we notice any new ones. AManWithNoPlan (talk) 17:56, 19 August 2018 (UTC)
https://github.com/ms609/citation-bot/pull/599 AManWithNoPlan (talk) 18:07, 19 August 2018 (UTC)
  Fixed AManWithNoPlan (talk) 00:02, 21 August 2018 (UTC)

More caps

Status
new bug
Reported by
Headbomb {t · c · p · b} 00:57, 20 August 2018 (UTC)
What happens
Ssrn, Ai, Woor
What should happen
SSRN, AI, woor
Relevant diffs/links
[6] [7]
We can't proceed until
Agreement on the best solution


https://github.com/ms609/citation-bot/pull/619/files AManWithNoPlan (talk) 16:26, 20 August 2018 (UTC)

  Fixed AManWithNoPlan (talk) 23:39, 20 August 2018 (UTC)

ISBN numbers

Status
  Not a bug
Reported by
Gderrin (talk) 01:53, 20 August 2018 (UTC)
What happens
It is probably of little consequence, but this bot is changing ISBN numbers from the number given in the actual frontispiece of the books concerned (or at least the books I have quoted in articles). For example, the ISBN number given in "Verticordia, the turner of hearts" in Verticordia subg. Verticordia is 1 876268 46 8, but the bot has changed it to 978-1-876268-46-6. (The former number is used in more than 100 Verticordia articles.) Similarly it has changed 0 646 402439 to 978-0646402437 in Melaleuca shiressii. Both numbers seem to work but I wonder the purpose of changing. No big deal - just curious. Gderrin (talk) 02:52, 20 August 2018 (UTC)


Are referring to the ISBN 10 to 13 fixing? AManWithNoPlan (talk) 01:59, 20 August 2018 (UTC)

also white space should not be used in isbn, so we remove it AManWithNoPlan (talk) 19:03, 20 August 2018 (UTC)

Google Books in Cite Web are not expanded

Yup. Note that for google books URLs, cite web won't expand, but cite book will expand. Headbomb {t · c · p · b} 15:00, 20 August 2018 (UTC)

I absolutely hate having to manually change those to cite book..... Not sure why I did not do this sooner: https://github.com/ms609/citation-bot/pull/617 AManWithNoPlan (talk) 15:22, 20 August 2018 (UTC)
  Fixed

Bot adds doi url

Status
  Fixed in Github Pull 618
Reported by
Headbomb {t · c · p · b} 15:21, 20 August 2018 (UTC)
Type of bug
Improvement: The bot would be much better if ...
What happens
Bot adds |url=http://doi.org/10.1007/s12668-011-0022-5
What should happen
Bot adds |doi=10.1007/s12668-011-0022-5
Relevant diffs/links
[8]
We can't proceed until
Agreement on the best solution


https://github.com/ms609/citation-bot/pull/618 AManWithNoPlan (talk) 15:37, 20 August 2018 (UTC)

  Fixed AManWithNoPlan (talk) 00:01, 21 August 2018 (UTC)

Translator link -> last##

Status
  Fixed
Reported by
Martin (Smith609 – Talk) 14:59, 21 August 2018 (UTC)
What happens
translator-link replaced with translator-last##
What should happen
We should never see ##s, which are placeholders
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Galileo_Galilei&diff=prev&oldid=855892437


The bot ran during a git pull and so the files were in an inconsistent state. AManWithNoPlan (talk) 15:16, 21 August 2018 (UTC)
Not sure how you figured that out, but glad to hear there's no underlying problem! (-: Martin (Smith609 – Talk) 15:21, 21 August 2018 (UTC)

work parameter

Making edits such as https://en.wikipedia.org/w/index.php?title=Katarzyna_Bachleda-Curuś&diff=prev&oldid=855644962 may be a violation of Wikipedia:COSMETICBOT. (tJosve05a (c) 20:49, 19 August 2018 (UTC)

I don't really understand why the bot would remove parameters like that there. Not only is it cosmetic, the edit doesn't make sense. --Izno (talk) 20:56, 19 August 2018 (UTC)
It is done to discourage the use of the generic and often misused |work=. In almost all cases, the |journal=, |website=, etc. are better choices. Also, in this case |publisher= is already set to the wrong thing, it should use |website= instead, which is an alias for |work=. AManWithNoPlan (talk) 21:17, 19 August 2018 (UTC)
I will work on code to do a better job. AManWithNoPlan (talk) 21:20, 19 August 2018 (UTC)
Here is the improvement. https://github.com/ms609/citation-bot/pull/614 If an alias of |work= is filled in, the the empty |work= will be removed to discourage future adding of it which would be an error. If an alias of |work= is not set, then it will be changed to a template specific parameter if relevant: for example inf {{cite journal}} the empty |work= will be changed to an empty |journal=. AManWithNoPlan (talk) 21:37, 19 August 2018 (UTC)
Just ensure it is compliant with Wikipedia:COSMETICBOT or have gotten Wikipedia:BAG approval to be making edits which will make no appearance difference. (tJosve05a (c) 21:42, 19 August 2018 (UTC)
WP:COSMETICBOT compliance is good for large-scale runs, but since the bot is user activated, it's not that big a deal if the bot does minor cleanup like that on select, user-requested pages. There's tons of cosmetic things (e.g. |page=|pages=), which would in theory be nice to categorize as cosmetic, but this realistically would only be an issue if you run the bot on categories. So maybe in 'category mode', it should skip the cosmetic stuff. Seems a like a very high time cost for little payoff though at this time, but would matter if the bot started to edit on its own. Headbomb {t · c · p · b} 00:34, 20 August 2018 (UTC)
  Fixed AManWithNoPlan (talk) 00:02, 21 August 2018 (UTC)

Put who activated the bot in the edit summary

Status
  Fixed
Reported by
Headbomb {t · c · p · b} 12:49, 21 August 2018 (UTC)
Type of bug
Improvement: The bot would be much better if ...
What happens
No mention of who activated the bot
What should happen
Mention who activated the bot


I'm pretty sure the bot used to mention who activated it at some point. This will be particularly important when the Category api will be invoked. Headbomb {t · c · p · b} 12:49, 21 August 2018 (UTC)

Raw url refs

Status
  Fixed
Reported by
Headbomb {t · c · p · b} 03:20, 20 August 2018 (UTC)
Type of bug
Improvement: The bot would be much better if ...
What happens
Nothing
What should happen
Start with
  • <ref>http://example.com</ref> (with whitespace variations)
  • <ref>[http://example.com]</ref>

Pre-process: convert to

Then process as usual. If there's a result, use that. If not, keep raw. The idea is that you could go from

to

  1. ^ Mahajan, Priyanka Thukral; Pimple, Priya; Palsetia, Delnaz; Dave, Nahid; De Sousa, Avinash (2013). "Indian religious concepts on sexuality and marriage". Indian Journal of Psychiatry. 55 (Suppl 2): S256–S262. doi:10.4103/0019-5545.105547. PMC 3705692. PMID 23858264.
  2. ^ Axelrod, Richard (2010). Terms of Engagement: New Ways of Leading and Changing Organizations. Berrett-Koehler Publishers. ISBN 9781605099590.


Not gonna happen. We work on templates only. That is basically a different bot. AManWithNoPlan (talk) 04:30, 20 August 2018 (UTC)

"Citation bot" has a scope of citations. There's no reason not to deal with raw urls. Headbomb {t · c · p · b} 04:32, 20 August 2018 (UTC)
we do nothing with references. We only do templates. It would require a completely different code base. AManWithNoPlan (talk) 04:34, 20 August 2018 (UTC)
It's already approved for this. See Wikipedia:Bots/Requests_for_approval/Citation_bot_8. Headbomb {t · c · p · b} 04:35, 20 August 2018 (UTC)
approved yes. Code no. AManWithNoPlan (talk) 04:38, 20 August 2018 (UTC)

The 'entirely new' codebase is a minute amount of pre-processing.

<ref([^>]*)>http(s)?:\/\/([^ \>]+)<\s*\/\s*ref>
  →
<ref$1>{{cite web |url=http$2://$3}}</ref>

If the bot gets a hit with that, expand, if not, keep raw url. Headbomb {t · c · p · b} 04:41, 20 August 2018 (UTC)

Actually not that simple. Search needs to be non greedy. Would need to have some type of bogus parameter set to either completely revert at end or just remove the specific flag. Lots of testing, and that’s the pain. AManWithNoPlan (talk) 04:54, 20 August 2018 (UTC)
Point is, this wouldn't be an epic 3-months long development process. Yes some thought needs to be put into it, but the codebase for recognizing stuff from URLs is relatively mature. If that gets a hit, whatever you're going to have will beat the raw url. And it'll save doing [9] before running the bot to get [10]. Headbomb {t · c · p · b} 04:58, 20 August 2018 (UTC)

Laying in bed it came to me:

  1. search for and change to cite web, but with extra CITATION_BOT parameter that is encrypted url
  2. do normal bot stuff
  3. when writing out look for CITATION_BOT flag and If no title is set then just decrypt url and echo that. If title is set remove special flag.

We have do that since url might get upgraded but find no title, such as citeseerer or bad doi. AManWithNoPlan (talk) 12:59, 20 August 2018 (UTC)

More information;

  1. the backup url is encrypted to hide it from bot
  2. CITATION_BOT is a magic phrase so if we leave one in the Bot will notice
  3. we have unused code to call Citoid but they throttle us too much
  4. we need to reject any urls with spaces or set braces or square braces just to be safe
  5. we would want to try this on the dev bot first

AManWithNoPlan (talk) 13:10, 20 August 2018 (UTC)

Work in progress https://github.com/ms609/citation-bot/pull/621 AManWithNoPlan (talk) 20:28, 20 August 2018 (UTC)

Note, <ref([^>]*)>\[?http(s)?:\/\/([^ \>]+)\]?\s*<\s*\/\s*ref> works better. Headbomb {t · c · p · b} 20:41, 20 August 2018 (UTC)
Opinions on this https://github.com/ms609/citation-bot/pull/628 AManWithNoPlan (talk) 19:34, 21 August 2018 (UTC)
No opinion on the technical side of things, but that's pretty much what I suggested above, so I'm all for it. Headbomb {t · c · p · b} 19:35, 21 August 2018 (UTC)
Seems to be missing \[? and \]? around the URL to catch <ref>[http://example.com]</ref> Headbomb {t · c · p · b} 19:39, 21 August 2018 (UTC)
Character escaping seems off, my understand is that '\>' could be '>'. That or all the other '<' or '>' need to be escaped. Headbomb {t · c · p · b} 19:43, 21 August 2018 (UTC)
No longer escape things that do not need escapes in RegEx. Added support for [http.....] AManWithNoPlan (talk) 20:03, 21 August 2018 (UTC)
Very much looking forward to test this. I've got plenty of pages in the pipeline. Headbomb {t · c · p · b} 20:08, 21 August 2018 (UTC)

This works, so, sooooooooooo well it's insane. Whenever it fails, it's because there's an actually problem with the url/identifiers. This is amazing. Headbomb {t · c · p · b} 14:18, 22 August 2018 (UTC)

Deleted google books URL listed even though nothing is deleted

I've noticed this a few times now; there's an example visible at

https://tools.wmflabs.org/citations/doibot.php?page=Talk:Galileo%20Galilei

See that line

 - https://books.google.com/books

? We must be adding and removing this URL somewhere along the line, because we're not editing the citation...

Martin (Smith609 – Talk) 14:44, 21 August 2018 (UTC)

Possibly related to User talk:Citation bot#Raw url refs or User talk:Citation bot#Google Books in Cite Web are not expanded? Headbomb {t · c · p · b} 14:59, 21 August 2018 (UTC)
It is not doing anything other than echoing that url. Strange. AManWithNoPlan (talk) 15:11, 21 August 2018 (UTC)
https://github.com/ms609/citation-bot/pull/627 AManWithNoPlan (talk) 15:50, 21 August 2018 (UTC)
  Fixed

New feature request, run from talk category

Using the bot on Category:Draft-Class Astronomy articles will, obviously, run the bot on that category.

However, it would be very useful to have the bot run on the main pages associated with those talk pages in the category. I.e. take all pages in Category:Draft-Class Astronomy articles, convert to main pages, and run the bot on those. Perhaps via something like

or

Headbomb {t · c · p · b} 14:39, 17 August 2018 (UTC)

https://tools.wmflabs.org/citations/category.php?cat=Draft-Class_Astronomy_articles&talk=1 would be the way to go. The Bot would get a list of the category and then add "Talk:" to each page title (or change "User:" to "User_Talk:" in the case of user pages or just ignore user talk pages). AManWithNoPlan (talk) 18:28, 19 August 2018 (UTC)
  • Possible solution [Suggestion 1]: modify function category_members in WikiFunctions.php so that it removes the namespace from all pages that it queues up to visit. I can't think of many situations when one would want to run the bot on pages outside the main namespace, and it could be disruptive if someones deliberately included an incorrectly formatted citation in a discussion.
  • Alternative solution [Suggestion 2]: Add the main namespace equivalent of each Talk page to the array of pages to be visited.

Martin (Smith609 – Talk) 14:19, 21 August 2018 (UTC)

I've gone ahead and implemented suggestion 1. Martin (Smith609 – Talk) 14:54, 21 August 2018 (UTC)
@Smith609: Which is suggestion 1? Or more clearly, what's the syntax for this? Headbomb {t · c · p · b} 19:44, 21 August 2018 (UTC)
Whatever he did, he did not commit it to github AManWithNoPlan (talk) 19:47, 21 August 2018 (UTC)
https://tools.wmflabs.org/citations/category.php?cat=Draft-Class_Astronomy_articles now visits all mainspace articles whose talk pages are in Category:Draft-Class_Astronomy_articles. Martin (Smith609 – Talk) 05:08, 22 August 2018 (UTC)
@Smith609: that's not very useful though (Mainspace articles associated with draft talk? What'd be the use of that?). What would be useful is if it visited the [[Foobar:<...>]] pages associated with [[Foobar talk:<...>]]. Headbomb {t · c · p · b} 11:17, 22 August 2018 (UTC)
  • Ah, I'd missed the introduction of the "Draft" namespace. I see what you are trying to accomplish now.   Fixed in Github Pull 641. Martin (Smith609 – Talk) 09:18, 24 August 2018 (UTC)
    • @Smith609: so now it works as {Suggestion 2}? Headbomb {t · c · p · b} 11:09, 24 August 2018 (UTC)
      • Yep, should do. Let me know how you get on. Martin (Smith609 – Talk) 12:46, 24 August 2018 (UTC)
        • @Smith609: works flawlessly. Save for all the other bugs, which are now much more efficiently triggered! Headbomb {t · c · p · b} 16:32, 24 August 2018 (UTC)

Better pubmed url recognition

Status
new bug
Reported by
Headbomb {t · c · p · b} 16:01, 21 August 2018 (UTC)
What happens
When running on [11] (see last url in the diff, |url=https://www.ncbi.nlm.nih.gov/sites/entrez/17906597 ... ), nothing happen. If the citation is converted to use a pmid [12], then it works [13].
What should happen
Recognize the URL, then do the bot thing
We can't proceed until
Feedback from maintainers


https://en.wikipedia.org/w/index.php?search=in-source%3A%22https%3A%2F%2Fwww.ncbi.nlm.nih.gov%2Fsites%2Fentrez%2F%22&title=Special:Search&profile=default&fulltext=1&searchToken=k3ig3e0tgj7hn3p0ig9gmvkk Does not look worth it to me AManWithNoPlan (talk) 21:52, 21 August 2018 (UTC)

Better search: [14] but you might be right here. Headbomb {t · c · p · b} 22:50, 21 August 2018 (UTC)
That link gives no hits. AManWithNoPlan (talk) 23:46, 21 August 2018 (UTC)
Better [15]. Headbomb {t · c · p · b} 00:04, 22 August 2018 (UTC)
most of those do not link to and article AManWithNoPlan (talk) 03:01, 22 August 2018 (UTC)
All of those do? [16] = PMID 17046367. &uid= is the pmid, see [17]. Headbomb {t · c · p · b} 04:17, 22 August 2018 (UTC)
interesting. The links are dead, but the pmid is in the link AManWithNoPlan (talk) 04:34, 22 August 2018 (UTC)
Well they're not dead for me. Headbomb {t · c · p · b} 15:10, 22 August 2018 (UTC)
Dead on the mobile site. Interesting. That’s a good reason to recognize and fix. AManWithNoPlan (talk) 15:18, 22 August 2018 (UTC)
  Not a bug Fixed them all by hand since only a couple were in citation templates. AManWithNoPlan (talk) 22:14, 26 August 2018 (UTC)

Caps: der der

  Won't fix See [18].Headbomb {t · c · p · b} 21:55, 26 August 2018 (UTC)

back to back der seems to not work right. AManWithNoPlan (talk) 22:13, 26 August 2018 (UTC)
Then don't bother fixing. der der is obviously a typo. Headbomb {t · c · p · b} 22:16, 26 August 2018 (UTC)

Category edit summary should mention who activated the bot when possible

E.g. [19]

This was activated via https://tools.wmflabs.org/citations/doibot.php?edit=toolbar&slow=1&user=Headbomb&cat=Particle_physics%20stubs

And the edit summary should reflect this. Possibly even deny category runs without a &user= value specified. Headbomb {t · c · p · b} 01:22, 23 August 2018 (UTC)

Working for me:

https://tools.wmflabs.org/citations/category.php?cat=X1&user=Smith609 generated https://en.wikipedia.org/w/index.php?title=User%3ADOI+bot%2FZandbox&diff=prev&oldid=856337766

Category.php will now show a note where the username is invalid or not specified.
As you're making more use of it I'll add a user-friendly interface to doibot.html in the future, to save manually editing URLs... Martin (Smith609 – Talk) 14:27, 24 August 2018 (UTC)
I'm triggering it via User:Headbomb/citations.js, but that would be a great features for the average Wikipedian. Might want to implement this in Wikipedia:Citation expander too, but I'd rather wait till we have a "run on list" (would be very useful in the Book: namespace, e.g. Book:Canada) and throttling before making that request. Headbomb {t · c · p · b} 14:34, 24 August 2018 (UTC)
  Fixed in Github Pull 660 Now you can prompt the bot to edit multiple pages by separating their names with a pipe, e.g. "page1|page2". Martin (Smith609 – Talk) 19:59, 24 August 2018 (UTC)
Interesting, although I don't know that it's very user-friendly to do that. Couldn't easily run it on say, Book:Canada or User:Headbomb/Sandbox4. And I'm not sure it could handle having 2000 articles shoved in as article1|article2|...|article1999|article2000. Headbomb {t · c · p · b} 20:58, 24 August 2018 (UTC)

Caps: della

[20]. Headbomb {t · c · p · b} 00:27, 23 August 2018 (UTC)

  Fixed in Github Pull 638 AManWithNoPlan (talk) 23:46, 23 August 2018 (UTC)

More caps: um, von

Status
  Fixed in Github Pull 538
Reported by
Headbomb {t · c · p · b} 22:57, 23 August 2018 (UTC)
What happens
um --> Um, von --> Von
What should happen
um / von stay um / von
Relevant diffs/links
[21]
We can't proceed until
Feedback from maintainers


https://github.com/ms609/citation-bot/pull/638 AManWithNoPlan (talk) 23:45, 23 August 2018 (UTC)

  • I have a similar one, the Dutch "en", which means "and", should not be capitalised to "En" either, as done here at the bottom:[22] FunkMonk (talk) 04:13, 24 August 2018 (UTC)

https://github.com/ms609/citation-bot/pull/650 AManWithNoPlan (talk) 15:05, 24 August 2018 (UTC)

Capitalising every word in journal names

This is more a question than a bug report, is it intentional that all words that are normally not capitalised, such as "the, as, in, an, of" etc., in journal names are now capitalised? And now it seems another bot is changing some of this back? FunkMonk (talk) 16:14, 23 August 2018 (UTC)

Journals should use title case, so if something doesn't use title case, that would be an issue. Converting to title case is fine and encouraged. Note that there was a bug in Citation bot that capitalized journals by mistake for a little while, that's fixed now. Headbomb {t · c · p · b} 16:18, 23 August 2018 (UTC)
Ok, that was what I was referring to, seems I had not completed the sentence above. FunkMonk (talk) 16:47, 23 August 2018 (UTC)

  Not a bug. Fixed already AManWithNoPlan (talk) 23:07, 23 August 2018 (UTC)

doibot.php incorrectly thinks nothing changed and avoids null edit

Status
  Fixed
Reported by
Headbomb {t · c · p · b} 16:40, 23 August 2018 (UTC)
What happens
Tetrahedron letters isn't capitalized
What should happen
[23]
Relevant diffs/links
[24] fix by JCW-CleanerBot (running Citation bot on the page did nothing)


To be clear, I tried running Citation bot on this today, and it failed to update the caps. So I did it via JCW-CleanerBot instead. It just so happened that Citation bot made the last edit before JCW-CleanerBot. Headbomb {t · c · p · b} 23:57, 23 August 2018 (UTC)

how are launching the bot? It worked for me both master and dev version AManWithNoPlan (talk) 00:17, 24 August 2018 (UTC)
Via [25]. Test page is setup at User:Headbomb/sandbox4. Headbomb {t · c · p · b} 00:31, 24 August 2018 (UTC)
doibot.php incorrectly does not notice some changes. Because nothing was reported as changed the bot avoided doing a null edit AManWithNoPlan (talk) 01:47, 24 August 2018 (UTC)
@AManWithNoPlan: so what's the most bleeding edge / most advanced code / unstable code available to mortals? Headbomb {t · c · p · b} 01:50, 24 August 2018 (UTC)
the gadget api where you are editing the file works right. Also if there had been more to do on the page then it would have done the modifications-AManWithNoPlan (talk) 01:56, 24 August 2018 (UTC)
[26] Another one. It's really annoying to have to do them by hand when the bot could be fixed them. Headbomb {t · c · p · b} 00:05, 25 August 2018 (UTC)

https://github.com/ms609/citation-bot/pull/666 The pull of the beast AManWithNoPlan (talk) 01:21, 25 August 2018 (UTC)

\m/(-_-)\m/ Headbomb {t · c · p · b} 01:21, 25 August 2018 (UTC)

Erroneously upgrades cite arxiv to cite journal

Status
  Fixed in Github Pull 647
Reported by
Headbomb {t · c · p · b} 11:41, 24 August 2018 (UTC)
What happens
* {{cite arxiv|last=Meyertholen|first=Andrew|last2=Di Ventra|first2=Massimiliano|date=2013-05-31|title=Quantum Analogies in Ionic Transport Through Nanopores|eprint=1305.7450|class=cond-mat.mes-hall}}

switched to

  • {{Cite journal|last=Meyertholen|first=Andrew|last2=Di Ventra|first2=Massimiliano|date=2013-05-31|title=Quantum Analogies in Ionic Transport Through Nanopores|arxiv=1305.7450|bibcode=2013arXiv1305.7450M}}
 > Checking AdsAbs database
   > AdsAbs search 3177/50000:
       arXiv:"1305.7450"
   + Adding bibcode: 2013arXiv1305.7450M
   ~ Renamed "eprint" -> "arxiv"
   - Dropping parameter "class"
What should happen
keep {{cite arxiv}} as cite arxiv
Relevant diffs/links
[27] (was activated via https://tools.wmflabs.org/citations/category.php?cat=Draft-Class_physics_articles&slow=1 if it matters)
We can't proceed until
Feedback from maintainers


bibcodes typically denote journals. The bot now (PR 647) won't assume that a bibcode denotes a journal, if the bibcode contains the string "arxiv". Are there any other cases that we should watch out for? Martin (Smith609 – Talk) 12:00, 24 August 2018 (UTC)

There are. I'll get a list. Headbomb {t · c · p · b} 12:04, 24 August 2018 (UTC)
####arXiv
####gr.qc
####hep.ex
####hep.lat
####hep.ph
####hep.th
####math.ph
####math
####nucl.ex
####nucl.th
####physics

#### being years. That should cover it. You could simplify it to ####hep, ####math and ####nucl for those with sub-arxivs. Actually no, that might lead to some collisions. Headbomb {t · c · p · b} 12:09, 24 August 2018 (UTC)

Thanks for the list. These additions   Fixed in Github Pull 654. Martin (Smith609 – Talk) 18:00, 24 August 2018 (UTC)

Feature request: Throttle rate on categories to comply with BOTPOL

Status
  Fixed in Github Pull 653 (untested)
Reported by
Headbomb {t · c · p · b} 12:34, 24 August 2018 (UTC)
What happens
Citation bot speeds through a category as fast as it can
What should happen
Throttle edits to 6 EPM
We can't proceed until
Feedback from maintainers


WP:BOTPOL suggests that rate for non-critical tasks. While I'm not a stickler for rules, the potential for damage is relatively high, especially in several WP:BEANS scenario (it just edited at a rate of 25 EPM on a recent run!). So implementing a per-activation throttle would be best. Headbomb {t · c · p · b} 12:34, 24 August 2018 (UTC)

I've coded a throttle, but not tested it; I'd be grateful if you could keep an eye out and see whether you notice throttling in action! Martin (Smith609 – Talk) 17:44, 24 August 2018 (UTC)
@Smith609: seems to work. I unleashed it on Category: CS1 maint: PMC format which had 15 very easy edits to make, and it cleared it at 6 EPM. The category API doesn't update during the run, but you do get the results after the run. Not sure if the throttle is 'smart' (edits at 6/min) or 'dumb' (processes at 6/min), but it's working. Headbomb {t · c · p · b} 18:13, 24 August 2018 (UTC)
Great. The script now keeps track of when it last edited, and makes sure that this was at least 10 seconds ago, which probably makes it 'semi-smart' (as if it spent the first 50 seconds of a minute without making an edit, it could squeeze five into the last ten seconds!) Martin (Smith609 – Talk) 06:38, 25 August 2018 (UTC)

Fails to upgrade Cite Web to Cite Book

Status
  Fixed in Github Pull 652
Reported by
Headbomb {t · c · p · b} 12:51, 24 August 2018 (UTC)
What should happen
Cite web → Cite book when there's an ISBN
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Draft:Gerard_J._Gianoli&diff=prev&oldid=856327250
We can't proceed until
Feedback from maintainers


Caps: og

Status
  Fixed in Github Pull 669
Reported by
Headbomb {t · c · p · b} 02:39, 25 August 2018 (UTC)
What happens
og --> Og
What should happen
keep as og
Relevant diffs/links
[28]
We can't proceed until
Feedback from maintainers


More caps: al, delle

See [29]. Headbomb {t · c · p · b} 10:10, 26 August 2018 (UTC)

  Fixed

Remove archive when removing url

Status
  Fixed in Github Pull 632
Reported by
(tJosve05a (c) 21:08, 21 August 2018 (UTC)
What happens
If an citation has a doi and a URL with a known DOI, the bot removes the URL. It however does not remove |archive-url= (or |archiveurl=) and |archive-date= (or |archivedate=).
What should happen
If it removes |url=, also remove |archive-url= (or |archiveurl=) and |archive-date= (or |archivedate=).
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Complications_of_pregnancy&diff=855940217&oldid=855915372
We can't proceed until
Feedback from maintainers


https://github.com/ms609/citation-bot/pull/632 AManWithNoPlan (talk) 23:59, 21 August 2018 (UTC)   Fixed

No more capitalization

do should not be capitalized (at least not in Memórias Do Instituto Oswaldo Cruz), see https://en.wikipedia.org/w/index.php?title=Leptoconops&diff=prev&oldid=855945017 (tJosve05a (c) 21:49, 21 August 2018 (UTC)

The Tower of Babel strikes again. AManWithNoPlan (talk) 22:01, 21 August 2018 (UTC)
https://github.com/ms609/citation-bot/pull/631 AManWithNoPlan (talk) 22:02, 21 August 2018 (UTC)

  Fixed

Forget more things

Forget |via=[[JSTOR]] (or |via=JSTOR) and |registration= if the bot forgets |url=https://www.jstor.org/stable/29780032 in favor of |jstor=; see https://en.wikipedia.org/w/index.php?title=Sir_John_Ellerman,_1st_Baronet&diff=prev&oldid=855994139 (tJosve05a (c) 05:58, 22 August 2018 (UTC)

In general |access-date= / |archive-date= / |archive-url= / |dead-url= / |format= / |registration= / |subscription= / |url-access= / |via= can be all be omitted if there are no url. |format= is tricky though, since it's abused for a lot of things that should be in |type= instead. Headbomb {t · c · p · b} 13:13, 22 August 2018 (UTC)
https://github.com/ms609/citation-bot/pull/637 AManWithNoPlan (talk) 23:38, 23 August 2018 (UTC)

  Fixed

access icon parameter left behind after url removed

Status
  Fixed in Github Pull 637
Reported by
Trappist the monk (talk) 13:39, 22 August 2018 (UTC)
What happens
bot removes |url=, |archive-url=, |archive-date= leaves behind |url-access= and |dead-url=
What should happen
|url-access= and |dead-url= should have been deleted
Relevant diffs/links
this edit
We can't proceed until
Feedback from maintainers


From this:

{{Cite journal |last1=Levasseur |first1=David G. |last2=Sawyer |first2=J. Kanan |date=August 19, 2006 |title=Pedagogy Meets PowerPoint: A Research Review of the Effects of Computer-Generated Slides in the Classroom |url=https://www.tandfonline.com/doi/full/10.1080/15358590600763383 |url-access=subscription <!-- but archive is ungated --> |journal=Review of Communication |issn=1535-8593 |publisher=Taylor and Francis |volume=6 |issue=1–2 |pages=101–123 |doi=10.1080/15358590600763383 |archive-url=https://www.webcitation.org/6YM4kjvL0?url=http://www.tandfonline.com/doi/full/10.1080/15358590600763383 |dead-url=no |archive-date=May 7, 2015 |access-date=September 23, 2017 |quote= [quotation redacted]}}

the bot produced this:

{{Cite journal |last1=Levasseur |first1=David G. |last2=Sawyer |first2=J. Kanan |date=August 19, 2006 |title=Pedagogy Meets PowerPoint: A Research Review of the Effects of Computer-Generated Slides in the Classroom |url-access=subscription <!-- but archive is ungated --> |journal=Review of Communication |issn=1535-8593 |volume=6 |issue=1–2 |pages=101–123 |doi=10.1080/15358590600763383 |dead-url=no |quote= [quotation redacted]}}
Levasseur, David G.; Sawyer, J. Kanan (August 19, 2006). "Pedagogy Meets PowerPoint: A Research Review of the Effects of Computer-Generated Slides in the Classroom". Review of Communication. 6 (1–2): 101–123. doi:10.1080/15358590600763383. ISSN 1535-8593. [quotation redacted] Unknown parameter |dead-url= ignored (help); |url-access= requires |url= (help)

Trappist the monk (talk) 13:39, 22 August 2018 (UTC)

See also User talk:Citation bot#Forget more things. Headbomb {t · c · p · b} 14:00, 22 August 2018 (UTC)

https://github.com/ms609/citation-bot/pull/637 AManWithNoPlan (talk) 23:38, 23 August 2018 (UTC)

Strip dot at end of volume/issue/page/pages

Status
  Fixed in Github Pull 671
Reported by
Headbomb {t · c · p · b} 23:56, 22 August 2018 (UTC)
What happens
Nothing
What should happen
|volume/issue/page/pages=1-12.|volume/issue/page/pages=1-12
We can't proceed until
Feedback from maintainers


Could be generalized to any punctuation (.,;:… or ...). Headbomb {t · c · p · b} 01:58, 24 August 2018 (UTC)

Drop more parameters when dropping url

Status
  Fixed
Reported by
(tJosve05a (c) 09:16, 23 August 2018 (UTC)
What happens
The bot replaced {{Cite web |url=http://www.jstor.org/stable/3744263 |website=Agricultural History}} with
{{Cite journal |jstor=3744263 |journal=Agricultural History |website=Agricultural History}}
What should happen
The bot should forget/drop |website=
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Mauritius&diff=prev&oldid=856162571


https://github.com/ms609/citation-bot/pull/637 AManWithNoPlan (talk) 23:37, 23 August 2018 (UTC)

More raw url fixings (JSTOR)

The bot should be able to detect that https://www.jstor.org/stable/pdf/10.1525/j.ctt1ffjn5h.6.pdf is the same as https://www.jstor.org/stable/10.1525/j.ctt1ffjn5h.6 and be able to expand that. It failed to do so here https://en.wikipedia.org/w/index.php?title=Mughal%E2%80%93Safavid_War_(1649%E2%80%9353)&diff=prev&oldid=856169186 (tJosve05a (c) 11:24, 23 August 2018 (UTC)

See also [30]. Headbomb {t · c · p · b} 11:41, 23 August 2018 (UTC)

  Fixed in Github Pull 657 Martin (Smith609 – Talk) 19:03, 24 August 2018 (UTC)

No standard jstor urls

Status
  Fixed in Github Pull 651
Reported by
(tJosve05a (c) 11:34, 23 August 2018 (UTC)
What happens
The bot extracted |jstor=0022381613000030 from |url=http://www.jstor.org/stable/10.1017/s0022381613000030. That is an invalid JSTOR ID.
What should happen
|jstor=10.1017/s0022381613000030 should have been added
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=History_of_political_science&diff=856176149&oldid=856176133
We can't proceed until
Feedback from maintainers


Broken dois and removal of URLs

Maybe the bot shouldn't remove URLs with doi's in them, if the |doi= is broken (with a |doi-broken-date=). https://en.wikipedia.org/w/index.php?title=Israel&diff=prev&oldid=856185012

From

<ref>{{cite journal|url=http://opil.ouplaw.com/view/10.1093/law:epil/9780199231690/law-9780199231690-e1301|title=Israel, Occupied Territories|publisher=|doi=10.1093/law:epil/9780199231690/law-9780199231690-e1301|doi-broken-date=2018-07-07}}</ref>

to

<ref>{{cite journal|title=Israel, Occupied Territories|publisher=|doi=10.1093/law:epil/9780199231690/law-9780199231690-e1301|doi-broken-date=2018-08-23}}</ref>

(tJosve05a (c) 13:03, 23 August 2018 (UTC)

Great report, thanks.   Fixed in Github Pull 656 Martin (Smith609 – Talk) 18:38, 24 August 2018 (UTC)

UTF-8 encoding in JSTOR data not taken into account

The bot added this from JSTOR. It both looks weird, and the |first1= doens't have a ; to display the Ó character (which should be used instead directly instead of using HTML code.

|last1 = m&#Xf3;rdha|first1 = Pilip &#xd3

https://en.wikipedia.org/w/index.php?title=Achaidh_Leithdeircc&diff=prev&oldid=856303097 (tJosve05a (c) 08:32, 24 August 2018 (UTC)

See correct edit: https://en.wikipedia.org/w/index.php?title=Achaidh_Leithdeircc&diff=856304296&oldid=856303097 (tJosve05a (c) 08:34, 24 August 2018 (UTC)

  Fixed in Github Pull 655 Martin (Smith609 – Talk) 18:22, 24 August 2018 (UTC)

Further simplify research gate URLs

  Fixed in Github Pull 677 The bot should simplify

to

See [31], right before |bibcode= 2010BuSSA.100.2840C.

In general, the structure will be https://www.researchgate.net/profile/FOOBAR/publication/DIGITS...

Headbomb {t · c · p · b} 11:24, 26 August 2018 (UTC)

404 on doibot.php

Status
  Fixed
Reported by
(tJosve05a (c) 16:37, 26 August 2018 (UTC)
What happens
I get 404 - Not Found on https://tools.wmflabs.org/citations/doibot.php?edit=toolbar&slow=1&user=Josve05a&page=Fayette_Avery_McKenzie


The correct url ends in process_page.php AManWithNoPlan (talk) 17:27, 26 August 2018 (UTC)

There should perhaps be an 'internal redirect', since several scripts make use of it. Headbomb {t · c · p · b} 17:49, 26 August 2018 (UTC)
the official method has been fixed. Almost all of those have been broken for many years. AManWithNoPlan (talk) 17:53, 26 August 2018 (UTC)
the correct search is https://en.wikipedia.org/w/index.php?search=insource%3A%2Fdoibot%5C.php%2F+-insource%3ADOI_bot&title=Special:Search&profile=advanced&fulltext=1&ns2=1&searchToken=4x836wn6m7sw0hmzfe6bs818k not the one that you posted. I fixed both publicly editable pages, leaving a few peoples common.js files. AManWithNoPlan (talk) 18:02, 26 August 2018 (UTC)
When you put stuff in your our files such as User:Josve05a/citations.js, instead of just turning on the the citation bot option, you get what you get and you don't throw a fit. AManWithNoPlan (talk) 18:03, 26 August 2018 (UTC)
I'm not using that. I'm using User:Smith609/citations.js. (tJosve05a (c) 18:10, 26 August 2018 (UTC)
I've even forgotten I did even did that. It was due to the "official script" was broken for a few weeks/months back in 2014 if I can remember. It had been working ever since, so somehting recently changed. I didn't (mean to) throw a fit, I just wanted to draw attention to that the "old way" the script worked, just broke. (tJosve05a (c) 18:06, 26 August 2018 (UTC)
I have a copy of it for the dev version so, I had to fix that myself too. The "don't throw fit" is an american phrase used to warn kids in advance that complaints will not be listen too (my using is was mostly in jest). Here are some links to the official version AManWithNoPlan (talk) 18:11, 26 August 2018 (UTC)

https://en.wikipedia.org/wiki/MediaWiki:Gadget-citations.js

https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-citations.js

https://en.wikipedia.org/wiki/Wikipedia:Citation_expander

I hope you understand I only want to help out (with my limited knowledge) by reporting issues which are affecting me or which I'm noticing, and not trying to complain.   (tJosve05a (c) 18:22, 26 August 2018 (UTC)
The Smith scripts are not really updated anymore since we got official support from media wiki. He should probably remove them actually. AManWithNoPlan (talk) 18:12, 26 August 2018 (UTC)
Yeah, some ([32]) are still using it. (tJosve05a (c) 18:13, 26 August 2018 (UTC)
  • Thanks for the report. I've updated the Smith script, and will keep an eye out for other outdated links (I couldn't turn any others up by Google). A redirect is probably a good idea too. Martin (Smith609 – Talk) 08:43, 27 August 2018 (UTC)

No longer expands/looks for bibcodes?

Status
  Fixed in Github Pull 684
Reported by
Headbomb {t · c · p · b} 22:19, 26 August 2018 (UTC)
Relevant diffs/links
Run the bot on User:Headbomb/sandbox3
We can't proceed until
Feedback from maintainers


And it even says "No need to repeat AdsAbs search for 1994ASAJ...96.1218T" 😏🤔🙄😂 AManWithNoPlan (talk) 22:24, 26 August 2018 (UTC)
Obviously! The bot knows it would just fail again! Headbomb {t · c · p · b} 22:45, 26 August 2018 (UTC)
@Smith609: This is partially fixed: [33] Headbomb {t · c · p · b} 11:58, 27 August 2018 (UTC)
Now fully fixed. [34]. Headbomb {t · c · p · b} 16:31, 27 August 2018 (UTC)

Google Books publisher

Please forget all variants of |publisher=Books.google.com from {{cite book}} (such as |publisher=, |work=, |website=, but also |foo=Google Books, |foo=Google, |foo=google.com etc. (tJosve05a (c) 19:28, 22 August 2018 (UTC)

See https://en.wikipedia.org/w/index.php?title=Japanese_hip_hop&diff=prev&oldid=856085189 (tJosve05a (c) 19:28, 22 August 2018 (UTC)
Agreed! Headbomb {t · c · p · b} 19:48, 22 August 2018 (UTC)
I hate seeing publisher=Google. Copyright-Thief=Books.Google.Com is cool though. AManWithNoPlan (talk) 01:00, 23 August 2018 (UTC)
Is via=Google Books permissible? Martin (Smith609 – Talk) 07:45, 25 August 2018 (UTC)
It is, but it's ... a relatively spammy practice. I remove it, but I don't think it would be appropriate for the bot to remove/add it.Headbomb {t · c · p · b} 20:08, 26 August 2018 (UTC)

{{fixed}}

Bug archiving is off temporarily

Once Cluebot III is running again this page will get cleaned up.

{{notabug}} flagging so that this goes away when fixed. AManWithNoPlan (talk) 20:25, 24 August 2018 (UTC)
Was just wondering about that myself. Thanks for checking! Martin (Smith609 – Talk) 20:19, 24 August 2018 (UTC)
still down. https://en.wikipedia.org/wiki/Special:Contributions/ClueBot_III AManWithNoPlan (talk) 20:24, 24 August 2018 (UTC)
It is back online. It may take a while to get to us. AManWithNoPlan (talk) 13:22, 27 August 2018 (UTC)

in cite journal, convert work/magazine/website to journal, in cite magazine, convert work/journal/website to magazine

Status
  Fixed in Github Pull 670
Reported by
Headbomb {t · c · p · b} 01:26, 25 August 2018 (UTC)
Relevant diffs/links
This would prevent this sort of issue from happening [35]
See line right above and including |magazine=[[Popular Astronomy (US magazine)|Popular Astronomy]]
We can't proceed until
Feedback from maintainers


We don't handle Cite Magazine. the bot'll now rename magazine to journal in cite journal. Martin (Smith609 – Talk) 07:31, 25 August 2018 (UTC)

Gadget API is down--fix submitted

https://github.com/ms609/citation-bot/pull/676 AManWithNoPlan (talk) 19:45, 26 August 2018 (UTC)

{{fixed}}

Don't strip ellipses (...)

Status
  Fixed in Github Pull 685
Reported by
Headbomb {t · c · p · b} 22:08, 26 August 2018 (UTC)
Relevant diffs/links
[36]
We can't proceed until
Feedback from maintainers


Don't assume JSTOR doi = valid DOI

Status
  Fixed in Github Pull 682
Reported by
Headbomb {t · c · p · b} 22:45, 26 August 2018 (UTC)
What happens
Adds bunk DOIs
What should happen
When you add |doi= from an apparent JSTOR doi in |jstor=, first check if it is broken before adding it to |doi=. JSTOR assigns internal DOIs all the time without registering them.
Relevant diffs/links
[37]
We can't proceed until
Feedback from maintainers


WTF citation change

Status
  Fixed in Github Pull 683
Reported by
Headbomb {t · c · p · b} 00:53, 27 August 2018 (UTC)
What happens
Changed

to

API gives



> Consult APIs to expand templates
 > Using pubmed API to retrieve publication details: 
   > Found match for pubmed identifier 11090370
   > Found match for pubmed identifier 29262068
   > Found match for pubmed identifier 21324708
   > Found match for pubmed identifier 14718418
   > Found match for pubmed identifier 26185361
   > Found match for pubmed identifier 18023732
   > Found match for pubmed identifier 11472968
   > Found match for pubmed identifier 18032698
   > Found match for pubmed identifier 28144783
   > Found match for pubmed identifier 6370120
   > Found match for pubmed identifier 30069044
   > Found match for pubmed identifier 30069046
   + Adding volume: 560
   + Adding issue: 7718
   + Adding pmid: 30069046
 > Checking PMID 30069046for more details
   + Adding doi: 10.1038/s41586-018-0394-6
   + Adding pmc: 6108322
   + Adding journal: Nature
   - Dropping parameter "publisher"
   - Dropping parameter "location"
   > Found match for pubmed identifier 25613900
   > Found match for pubmed identifier 25169055
   > Found match for pubmed identifier 24812003
   > Found match for pubmed identifier 21356587
   > Found match for pubmed identifier 19223979
   > Found match for pubmed identifier 22323207
   > Found match for pubmed identifier 23378277
   > Checking that DOI 10.1038/s41586-018-0394-6 is operational... DOI ok.
   > Checking that DOI 10.2214/ajr.175.6.1751537 is operational... DOI ok.
   > Checking that DOI 10.1016/j.ejcts.2010.12.028 is operational... DOI
Relevant diffs/links
[38]
We can't proceed until
Feedback from maintainers


Weird. Must be new multi-template code since it works fine on a single template AManWithNoPlan (talk) 02:36, 27 August 2018 (UTC)

I cannot reproduce it. Double weird. AManWithNoPlan (talk) 03:54, 27 August 2018 (UTC)
@AManWithNoPlan: Was caused by an invisible NSBP, which WP:WikEd exposed when I edited the page. Removing it fixed [39] the cause of the issue locally, but [40] seems to fix the issue being triggered in the first place everywhere. Headbomb {t · c · p · b} 11:54, 27 August 2018 (UTC)

Adds year when there is date

Status
{{notabug}} (actually not a new bug)
Reported by
Headbomb {t · c · p · b} 01:45, 27 August 2018 (UTC)
Relevant diffs/links
[41]
We can't proceed until
Feedback from maintainers


When it finds an arXiv year it adds it. AManWithNoPlan (talk) 02:35, 27 August 2018 (UTC)

Dupe of report above User talk:Citation bot/Archive_9#Adds year even if date is there after getting arxiv data. (tJosve05a (c) 11:57, 27 August 2018 (UTC)

Upgrade journal names

Status
{{wontfix}} because people like abbreviations....
Reported by
(tJosve05a (c) 13:14, 27 August 2018 (UTC)
What should happen
Rename all |journal=Foo J. with |journal=Foo Journal
We can't proceed until
Feedback from maintainers


This may need some research to see if there are exceptions. (tJosve05a (c) 13:14, 27 August 2018 (UTC)
I have always felt this would be good idea, but J Food is probably not Journal Food, but journal of Food or the journal of food. Every journal would be a special case. AManWithNoPlan (talk) 13:19, 27 August 2018 (UTC)
If the J. is of the end of a |journal= and the word Journal (or magazine) is not present, then it sounds to me a good bet that it should be replaced with |journal=Foo Journal. (tJosve05a (c) 13:26, 27 August 2018 (UTC)
Very, very bad idea, per WP:CONTEXTBOT, and per lack of consensus. If you want this to be done on a specific page, delete the abbreviations and run the bot again. Headbomb {t · c · p · b} 13:34, 27 August 2018 (UTC)
that’s what I do. Many people would consider this upgrade to be ‘worse than vandalism’. I consider them wrong, but there would blood everywhere AManWithNoPlan (talk) 13:52, 27 August 2018 (UTC)
(We could start a (small) list, and maintain it, and adding new journals one by one...but that's way much work) (tJosve05a (c) 13:53, 27 August 2018 (UTC)
The list or journal is huuuge, and you may run awry of WP:CITEVAR by messing consistently abbreviated journals in an article to a mish-mash of abbreviated-and-not-abbreviated journals in the same article. But if you get consensus for something like this, this would be better addressed by a different, possibly new bot.Headbomb {t · c · p · b} 14:10, 27 August 2018 (UTC)
Yes, a separate bot with separate approval. One page of php code. 300 pages of journal names. AManWithNoPlan (talk) 15:00, 27 August 2018 (UTC)

Support new parameter bot-deny

Status
{{wontfix}}
Reported by
Headbomb {t · c · p · b} 15:40, 21 August 2018 (UTC)
What happens
Bot edits all citations it can
What should happen
if |bot-deny=Citation bot or |bot-deny=yes is set, skip that citation
We can't proceed until
Feedback from maintainers


Note, the parameter doesn't yet exist, but I've made a request for it. Coding support for it should be rather trivial though. Headbomb {t · c · p · b} 15:40, 21 August 2018 (UTC)

No need for this, I found a better solution: User:Citation bot/use#... the bot made a mistake. Headbomb {t · c · p · b} 03:33, 29 August 2018 (UTC)

Adds year even if date is there after getting arxiv data

Status
{{Fixed}}
Reported by
Headbomb {t · c · p · b} 21:20, 24 August 2018 (UTC)
What happens
The line that reads |arxiv = nucl-ex/0106015 |year= 2001
Relevant diffs/links
[42]
We can't proceed until
Feedback from maintainers


Journal caps

Status
{{Fixed}}
Reported by
(tJosve05a (c) 13:12, 27 August 2018 (UTC)
What happens
The bot renmaes |journal=AAPS J. with |journal=Aaps J.
What should happen
Rename |journal=AAPS J. with |journal=The AAPS Journal
Rename |journal=AAPS Journal with |journal=The AAPS Journal

Keep caps in AAPS

Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=RTI-177&diff=856774737&oldid=835172566
We can't proceed until
Feedback from maintainers


There is no consensus for messing around with valid abbreviations. Fixing caps / title case is fine, but converting abbreviations to non-abbreviations is not, at least not without a strong consensus to do so.Headbomb {t · c · p · b} 13:31, 27 August 2018 (UTC)
In that case, it should keep caps. (tJosve05a (c) 13:39, 27 August 2018 (UTC)

Add support for non-standard jstor stable IDs

Status
Feature request
Reported by
(tJosve05a (c) 21:44, 27 August 2018 (UTC)
What happens
The bot converts a raw JSTOR link to a {{cite journal}} but doesn't add a |jstor=.
What should happen
The bot should have added |jstor=10.1086/673680 as in https://en.wikipedia.org/w/index.php?title=The_Steel_of_Madrid&diff=next&oldid=856843869
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=The_Steel_of_Madrid&diff=856843869&oldid=833050481
We can't proceed until
Feedback from maintainers


That has actually been debated and the belief at the time was that DOI was better than JSTOR and if they were exactly the same, then only list the DOI. This DOI is not owned by JSTOR, so it is not truly stable. JSTOR owns 10.2307 AManWithNoPlan (talk) 23:20, 27 August 2018 (UTC) {{notabug}}

Bibcodes still not reliably expanded

Status
{{notabug}}
Reported by
Lithopsian (talk) 13:20, 29 August 2018 (UTC)
What happens
Run the bot against a cite journal template with just a bibcode and nothing happens.
What should happen
templates with bibcodes should be expanded to a full citation
Relevant diffs/links
no links because nothing happens
Replication instructions
Test here: . Bibcode:2017A&A...600A.127K. Cite journal requires |journal= (help); Missing or empty |title= (help) This is intermittent (throttling?) and sometimes bibcodes are expanded properly. For example, five minutes ago this bibcode failed during an article edit (RS Puppis) but just now it worked right here.
We can't proceed until
Feedback from maintainers


The bot does sometimes get throttled by databases. Also, sometimes they just fail. AManWithNoPlan (talk) 14:51, 29 August 2018 (UTC)

Notice: updated user page

I updated the User:Citation bot user page to be prettier / more user friendly. Feel free to tweak. I also gave a major revamp the User:Citation bot/use guide. Please review/tweak, you can discuss the revamped guide at User talk:Citation bot/use#Revamp feedback. Headbomb {t · c · p · b} 17:17, 25 August 2018 (UTC)

Great! Thanks! Martin (Smith609 – Talk) 09:00, 27 August 2018 (UTC)
after a while just change that talk page to a redirect to here AManWithNoPlan (talk) 22:14, 27 August 2018 (UTC)

{{fixed}}ed it up very nice!!! AManWithNoPlan (talk) 16:11, 31 August 2018 (UTC)

Both converts Template:Ndash to hyphen... and then to ndash

Status
{{fixed}}
Reported by
Headbomb {t · c · p · b} 02:58, 25 August 2018 (UTC)
What should happen
Keep {{ndash}} as is
Relevant diffs/links
[43] [44]
We can't proceed until
Feedback from maintainers


it has a page number without a - character so the bot assumes a single page number and thus when it gets a range of pages it upgrades to the range. Pages are one of the few things we might blow away and replace. AManWithNoPlan (talk) 04:45, 25 August 2018 (UTC)

Don't overwrite comments

Status
{{fixed}}
Reported by
Martin (Smith609 – Talk) 15:09, 21 August 2018 (UTC)
What happens
Comment replaced by pagination information
What should happen
From memory, previous advice on this page was that if a bot should not populate a parameter (e.g. if an external database generates a false positive), the bot could be deterred by including an empty comment.
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Black_hole&diff=prev&oldid=855893224
We can't proceed until
Feedback from maintainers


The bot has been overwriting comments for a long time. AManWithNoPlan (talk) 15:12, 21 August 2018 (UTC)
Oh dear; I wonder how much dud information has been introduced as a result! Even if there is a better way to deal with false positives, I'm not sure how we might make a transition now that a standard has been set... Martin (Smith609 – Talk) 15:20, 21 August 2018 (UTC)

https://github.com/ms609/citation-bot/pull/630 page numbers AManWithNoPlan (talk) 20:44, 21 August 2018 (UTC)

https://github.com/ms609/citation-bot/pull/629 series and ISSN AManWithNoPlan (talk) 20:44, 21 August 2018 (UTC)

I think that once these two pulls are in, the code should respect comments again. AManWithNoPlan (talk) 23:59, 21 August 2018 (UTC)

Still does it btw [45]. Headbomb {t · c · p · b} 16:37, 24 August 2018 (UTC)
of course it does. The code has not been changed yet AManWithNoPlan (talk) 17:12, 24 August 2018 (UTC)
Well it's pretty hard to tell what's in the bot and what isn't. Headbomb {t · c · p · b} 17:15, 24 August 2018 (UTC)

More than one of |at= and |pages= specified

Status
{{fixed}}
Reported by
Renerpho (talk) 17:33, 29 August 2018 (UTC)
What happens
The bot adds "pages" to citations, regardless of whether "at" is already defined. This results in an error.
What should happen
Only one of "pages" or "at" should be defined. The bot should not add "pages" if "at" has been defined.
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=KIC_8462852&type=revision&diff=852383617&oldid=851426226
We can't proceed until
Feedback from maintainers


Why have one page keyword when you can have five! (“At” is the only one that is special) https://github.com/ms609/citation-bot/pull/692 AManWithNoPlan (talk) 19:03, 29 August 2018 (UTC)

Fails to cleanup CiteSeerX url

Status
{{fixed}}
Reported by
Headbomb {t · c · p · b} 13:09, 22 August 2018 (UTC)
What happens
keeps |url=http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.923.345&rep=rep1&type=pdf
What should happen
Set |citeseerx=10.1.1.923.345 and get rid of |url=
Relevant diffs/links
[46] (there are 2 such citeseerx links it could convert)
We can't proceed until
Feedback from maintainers


https://github.com/ms609/citation-bot/pull/691 AManWithNoPlan (talk) 16:34, 28 August 2018 (UTC)

Removes periods in abbreviations when at the end of a title

Status
{{Duplicate Issue}}
Reported by
Richard J Kinch (talk) 22:20, 31 August 2018 (UTC)
What happens
Removes a period (i.e., full stop) at the end of a title, which period is there to punctuate an abbreviation
What should happen
Should not remove any periods which are parts of abbreviations
Relevant diffs/links
https://en.wikipedia.org/w/index.php?title=Longhorned_tick&diff=857274375&oldid=856187468
We can't proceed until
Feedback from maintainers


Duplicate of User_talk:Citation_bot#Removal_of_trailing_full_stop. Headbomb {t · c · p · b} 23:24, 31 August 2018 (UTC)

Return to the user page of "Citation bot/Archive 9".