MediaWiki talk:Modern.css

boxes

The links in the boxes above say nothing about modern (yet). I'm wondering if they should be commented out or something. MilesAgain (talk) 04:00, 29 January 2008 (UTC)

I just added the boxes above to start the page, and because all the other skins have them. However Modern probably should be mentioned there, plus some other skins like Chick aren't mentioned there yet either. I don't know enough about this to confidently meddle with mediawiki much, so I'll leave that up to someone else ;)

I left a query about this skin at Wikipedia:Village pump (technical)#Modern skin, concerning where the development/discussion for this skin was (permalink to lone reply). -- Quiddity (talk) 07:12, 29 January 2008 (UTC)

Bugs

stuff not right yet

But the reason I'm here is that

{{pp-semi|small=yes}}
{{Geolinks-US-cityscale|123.45|67.8}}{{featured article}}
== test ==

...produces what you see on the right (when Preferences/Gadgets/"Add an [edit] link for the introduction section of a page" is checked), which is wrong where the red arrows indicate.

Also, if you put a newline in front of {{featured article}}, the misplaced gold star disappears. MilesAgain (talk) 04:00, 29 January 2008 (UTC)

Misplaced gold star without the newline is the same in monobook. I've fixed the issue with it disappearing. Coordinates issue needs further investigation. —Random832 17:48, 31 January 2008 (UTC)

The problem is, it's not clear where coordinates should actually go - in monobook, there's extra headroom that it can go in because of the line "From Wikipedia, the free encyclopedia.". Any thoughts? —Random832 17:53, 31 January 2008 (UTC)

I would say push them down a few pixels from where they are now to stop them from colliding. I just clicked "Random article" a dozen times and there's always room for one line of text. The closest it comes is with an infobox or ambox, as in San Mateo, California. MilesAgain (talk) 09:37, 1 February 2008 (UTC)

Sizes must be specified in ems - also, I can't reproduce your problem (in fact, on my screen it _already_ overlaps with infoboxes). Do you think you could, with firebug, try different values for #mw_contentholder padding-top and #coordinates top, and find a combination that works? —Preceding unsigned comment added by Random832 (talk • contribs) 21:12, 1 February 2008 (UTC)

I've enabled #siteSub (and written a style for it based on the usermessage style) - i'll work on coordinates later tonight. —Random832 21:16, 4 February 2008 (UTC)

External links

Regular external links look fine, but links to pdfs don't have the little document icon that they do under monobook; they don't have anything. MilesAgain (talk) 22:40, 30 January 2008 (UTC)

fixed. —Random832 17:48, 31 January 2008 (UTC)

i've fixed this properly in the skin (added the missing images for documents, audio and video files). kate.

I got the impression that this (the pdf icon, anyway - other icons seem to be elsewhere) is actually a wikipedia-specific feature, in common.css; though there's of course no reason not to enable it globally if the icons ship with mediawiki. —Random832 15:00, 1 February 2008 (UTC)

no, this is a monobook feature (see skins/monobook/main.css around line 555). apparently, enwiki's Common.css changes the icon from monobook's to an Adobe icon. kate. —Preceding comment was added at 13:44, 3 February 2008 (UTC)

FA interwikis

Another problem with the star: {{Link FA}} isn't making them.

Truth contains [[is:Sannleikur]] {{Link FA|is}}

Note that there is an interwiki to is:, but no star. MilesAgain (talk) 14:47, 1 February 2008 (UTC)

 Done. —Random832 15:03, 1 February 2008 (UTC)

usermessage class

Hi, the "usermessage" class just shows up as unstyled text, instead of being a pleasant attention-grabbing box. --Kjoonlee 16:55, 1 February 2008 (UTC)

Reported. In the meantime, you can take the CSS code from there and put it in your user stylesheet. —Random832 17:35, 1 February 2008 (UTC)

fixed kate. —Preceding comment was added at 14:14, 3 February 2008 (UTC)

pre tag

Monospaced text doesn't seem to stand out as much as with Monobook.

Is this a bug? Or is it a feature..? :) And also, is this the right place to mention these things..? --Kjoonlee 08:48, 3 February 2008 (UTC)

fixed kate.

Font sizes

Can anyone explain to me why font sizes have to be set on every element?

body { ... font-size: x-small; }
#mw_main, #p-personal, #mw_header {
    font-size: 130%;
}

Wouldn't it be simpler to just not set the font size on either of those, and just let browser preferences work? (the end result is smaller than my browser setting, equivalent to "small" rather than "medium") —Random832 21:11, 4 February 2008 (UTC)

(note: fixing this will require reworking a number of margin and padding values to make it still look right) —Random832 21:14, 4 February 2008 (UTC)

== sitesub ==

i have a feeling this sitesub styling is going to look rather odd when combined with the new messages box, as they both have the gradient footer. i'll probably add something similar to the skin (for sitesub, usermessage, and maybe subtitle and the other top-of-page decoration), but done so only the lowest entry has the gradient. i'd suggest removing the sitesub for now as the css will probably conflict when that goes live... kate.

I already accounted for that, the usermessage covers the gradient on the sitesub. (that was what was taking me so long - that's what the margins in pixels are for - the reason for that is that the usermessage box is the bottom, but isn't always shown.) —Random832 21:19, 4 February 2008 (UTC)

I've taken it out so we can see how whatever you do works. —Random832 21:30, 4 February 2008 (UTC)

jsMsg

There should be an element in an appropriate place (and appropriately styled; to be invisible if empty - i'd recommend in the topboxes) with the id "mw-js-message". This is for e.g. the ajax watch script. —Random832 22:08, 13 February 2008 (UTC)

Keyboard shortcut prefixes

Hi, if you put your mouse pointer on some of Wikipedia's navigation links, you should get a tooltip about keyboard shortcuts: [alt-shift-.] for your user page, [alt-shift-n] for your user talk page, and so on, assuming you're using Firefox with Monobook.

However, with the Modern skin, only [alt-shift-f] for Search is displayed correctly; the others just show up as [z], [x], [r], etc.

Tested with the Firefox 2.0 and 3.0 beta branches on Windows. --Kjoonlee 16:22, 14 February 2008 (UTC)

No surprise, considering this skin breaks the traditional content / column-one page structure. The function updateTooltipAccessKeys() in wikibits.js updates tooltips on links only inside column-one. Something like this below in MediaWiki:Modern.js should fix this. -AlexSm 17:14, 14 February 2008 (UTC)

var tooltipsToFix = ['p-cactions', 'mw_portlets', 'p-personal'], block
for (var i in tooltipsToFix)
  if (block=document.getElementById(tooltipsToFix[i]))
    updateTooltipAccessKeys(block.getElementsByTagName('a'))

P.S. Please move this discussion into MediaWiki talk:Modern.js. -AlexSm 17:14, 14 February 2008 (UTC)

I think the discussion about the skin should stay in one place - I've redirected that title to this talk page. I'll work on getting this fixed later —Random832 19:45, 25 February 2008 (UTC)

I have added this. —TheDJ (talk • contribs) 01:19, 13 May 2009 (UTC)

Preferences page

Please (temporary) fix preferences page per User talk:Kate#Modern skin: missing "clear:both" on preferences page. -AlexSm 17:14, 14 February 2008 (UTC)

Is it going to be released?

I really dig this skin and was wondering if it's going to be publicly released or included with future versions of MediaWiki. --Johan (talk) 16:30, 16 February 2008 (UTC)

Yeh, I also was wondering if it is going to be releashed. OekelWm (talk) 15:10, 9 March 2008 (UTC)

it is in MW 1.12. kate.

ALL CAPS?

WHY OH WHY THE ALL CAPS???!!1eleven

Missing 'Cite this page'?

Is it intentional that there is no 'cite this page' with this skin? It's rather annoying Nil Einne (talk) 19:55, 6 April 2008 (UTC)

I think it's a known bug with the MediaWiki software. Bugzilla:13584 --Kjoonlee 21:17, 10 April 2008 (UTC)

The bug's been fixed, but the "cite this page" extension hasn't. --Kjoonlee 02:15, 1 June 2008 (UTC)

layout errors

Hi, today I noticed that templates which should be floating to the right don't. Also, the [edit] link for the lead section (available as a gadget) doesn't show up correctly either; it's too dark to show up on the dark pagename header. --Kjoonlee 12:29, 28 July 2008 (UTC)

An example is Template:Infobox actor. I've tried bypassing my cache. Tested with Firefox 3.0.1. --Kjoonlee 12:30, 28 July 2008 (UTC)

I'm having various issues with this skin as well, both with IE and Firefox. Didn't have these problems last Friday. Anyone know what happened? --Kbdank71 15:32, 28 July 2008 (UTC)

Apparently the skin is broken. [1] --Kbdank71 17:02, 28 July 2008 (UTC)

Edit counter

Edit counter at user's page is not visible. It is hidden behind other interface stuff. I've made a workaround which fixes the problem, but skin should be fixed in more ellegant way.

To apply my workaround just add following code to your user page/modern.css:

#qec_span                    {right: 15px; position: absolute; top: 0px;} /* places counter on the right side of header bar */
#qec_span > a                {color: white;} /* makes editions number visible on blue background */

Skalee (talk) 11:39, 30 April 2009 (UTC)

userbox

I created a Userbox for the Modern skin:

Code	Result
{{User:TachyonJack/Userboxes/ModernSkin}}	Modthis user prefers to view wikipedia with the modern skin	Usage

--TachyonJack (talk) 20:40, 22 July 2009 (UTC)

You may want to list it at Wikipedia:Userboxes, that page gets far more traffic than this one. 「ダイノガイ千？！」^{? · Talk⇒Dinoguy1000} 21:08, 22 July 2009 (UTC)

secure and unsecure link displays

With the protocol relative being the new way to display. Can we do away with the distinction between http: and https: type links and just have a universal approach protocol relative? — billinghurst sDrewth 23:05, 27 February 2012 (UTC)

Coordinates do not display well in Modern skin

Coordinates do not display correctly in this skin (see bug 33825. Applying this patch to this page should take care of the problem. — Preceding unsigned comment added by Jdlrobson (talk • contribs)

I suggest raising this at the Village Pump. If there is consensus for it then it should be implemented. --RA (talk) 20:40, 11 June 2012 (UTC)

I don't see any coordinates at all on my view of First Baptist Church (Montgomery, Alabama) in the default browser of Android 2.3.4. I assumed the article didn't have them, and spent over an hour on a wild goose chase for the right "First Baptist Church" in Montgomery (there are several). And why would we need consensus for fixing a bug? The bug was closed as invalid for some reason. ★NealMcB★ (talk) 20:15, 10 March 2015 (UTC)

Adding {{Link GA}} image

Add

li.GA {
list-style-image: url("//upload.wikimedia.org/wikipedia/commons/4/42/Monobook-bullet-ga.png");
}

I use Modern and I think that the Monobook image could work, and it's the same size and all. ~~Ebe123~~ → report 22:14, 10 September 2012 (UTC)

 Done. — Edokter (talk) — 17:42, 11 September 2012 (UTC)

MediaWiki:Modern.js: addOnloadHook has been deprecated

Since addOnloadHook has been deprecated. Could we change addOnloadHook on the first line of MediaWiki:Modern.js to $ or $(document).ready ? Chmarkine (talk) 03:03, 19 March 2014 (UTC)

Fixed it by simply removing it altogether. —TheDJ (talk • contribs) 10:51, 19 March 2014 (UTC)

External links icons removed

Hello! If this CSS adds or modifies icons shown after external links, you'll be interested in knowing that such icons have been removed from MediaWiki core, a change which will reach this wiki in few days. You may want to consider whether you still need them. If you have questions, please ask at bugzilla:63725. Regards, Nemo 09:45, 10 April 2014 (UTC)

MediaWiki:Modern.js

Should we... maybe just change the ids in the skin itself? -— Isarra ༆ 19:21, 16 January 2019 (UTC)

This is a year late Isarra, but can't we just be rid of this? Twinkle should be just fine without it: I think Twinkle was fixed in with this in 2010 but regardless, it works just fine in Modern on testwiki. Not sure about what else relies on this — it could be good to assess some items first — but this stems from 2008, back before Vector, when Monobook ruled the land. I'm a pretty avid Modern evangelist, but it's 2020 and I think we should just handle any "upgrades" as needed. ~ Amory (u • t • c) 11:03, 29 March 2020 (UTC)

@Amorymeltzer: Sounds good to me. -— Isarra ༆ 21:19, 3 April 2020 (UTC)

 Done ~ Amory (u • t • c) 18:48, 9 May 2020 (UTC)

@Amorymeltzer: For the record, I think VisualEditor relied on it (or rather: it accidentally mostly worked on Modern because of that, even though it wasn't supposed to). The issue was reported here: Wikipedia:Village pump (technical)#Visual editor not loading. But don't revert the changes, BrandonXLF has submitted a patch for the skin itself to change the IDs, which should make it work again (phab:T177243). Matma Rex talk 18:06, 14 May 2020 (UTC)

Nah, I will — saving VE's bacon on the best skin everModern is a good enough reason. I also suspect that may cause some issues with user scripts, but hopefully most fall back/prefer #content anyway... Is it going out next week? ~ Amory (u • t • c) 18:24, 14 May 2020 (UTC)

Yeah. Matma Rex talk 18:42, 14 May 2020 (UTC)

@Amorymeltzer: It should be fine to try this again now. Matma Rex talk 21:25, 1 June 2020 (UTC)

👍 ~ Amory (u • t • c) 02:29, 2 June 2020 (UTC)