User talk:Ebrahames/Advisor.js

Empty loop

I think the loop

for (var i = 0; i > 6; i++) {

from this edit should be

for (var i = 0; i < 6; i++) {

because 0 > 6 === false. Helder 20:59, 16 November 2012 (UTC)

I don't know Javascript, but if the parameters to for (;;){}; in Javascript are the same as in C, I would tend to agree - the middle one is not the terminating condition but the continuing condition. --Redrose64 (talk) 22:21, 16 November 2012 (UTC)

I have made the requested change. — Martin (MSGJ · talk) 12:50, 19 November 2012 (UTC)

Obsolete code

The element <tt> was deprecated, and is not valid in HTML5 (see e.g. Template talk:Tlx#HTML5 and <tt>). Consider using <code> instead. Helder 20:59, 16 November 2012 (UTC)

Edit Request

Please change all three uses of wgContentLanguage to mw.config.get('wgContentLanguage') --TerraCodes ^{(talk to me)} 22:27, 4 November 2016 (UTC)

I'm not sure if this should be part of this request or another one, but some other deprecated things to replace are wgServer, wgCanonicalNamespace, wgArticlePath, and two uses of wgTitle, which should be replaced with mw.config.get('wg...') in the same manner. Only uses prefixed by "window." need replacing, as shown in Special:Diff/641176852/748222510, since the others are local variables. —PC-XT+ 02:24, 7 November 2016 (UTC)

This user has long left the project, perhaps someone should just fork this and maintain it? — xaosflux ^Talk 05:17, 7 November 2016 (UTC)

Done — Martin (MSGJ · talk) 19:44, 7 November 2016 (UTC)